gitea_admin/sientia-dataops-scouter_temporal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SIENTIAPDE-1478

Browse Source 
Refactor API class to remove unnecessary blank line and improve code readability. Update test cases to rename 'timeout' parameter to 'request_timeout' for consistency.
This commit is contained in:
vitor-aignosi
2026-01-19 10:11:36 -03:00
parent dc38309348
commit 9dab8da5b3
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
scouter/activities/api.py
View File

@@ -136,7 +136,6 @@ class API(SientiaMonitoring):
) )
raise e raise e
latest_values['timestamp'] = latest_values['timestamp'].dt.strftime(DATETIME_FORMAT_WITH_TZ) latest_values['timestamp'] = latest_values['timestamp'].dt.strftime(DATETIME_FORMAT_WITH_TZ)
self.debug(f'Latest values: {latest_values.to_string()}', metadata=metadata) self.debug(f'Latest values: {latest_values.to_string()}', metadata=metadata)
@@ -144,7 +143,7 @@ class API(SientiaMonitoring):
# Normalize the package timestamp # Normalize the package timestamp
valid_timestamp_values = latest_values['timestamp'].dropna() valid_timestamp_values = latest_values['timestamp'].dropna()
latest_values['timestamp'] = valid_timestamp_values.max() latest_values['timestamp'] = valid_timestamp_values.max()
self.info(f'Gathered {len(latest_values)} tag values', metadata=metadata) self.info(f'Gathered {len(latest_values)} tag values', metadata=metadata)
return latest_values.to_dict(orient='records') return latest_values.to_dict(orient='records')

4
tests/activities/test_api.py
View File

@@ -141,7 +141,7 @@ async def test_get_tag_values_success(api_activity):
start_time='*-1d', start_time='*-1d',
max_count=10, max_count=10,
metadata=metadata['metadata'], metadata=metadata['metadata'],
timeout=30, request_timeout=30,
) )
assert len(result) == 3 assert len(result) == 3
@@ -195,7 +195,7 @@ async def test_get_tag_values_with_default_max_count(api_activity):
start_time='*-1h', start_time='*-1h',
max_count=1, max_count=1,
metadata=metadata['metadata'], metadata=metadata['metadata'],
timeout=15, request_timeout=15,
) )
assert len(result) == 1 assert len(result) == 1