From 9dab8da5b3fc5b351b7262f396e74fb74626cf70 Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Mon, 19 Jan 2026 10:11:36 -0300 Subject: [PATCH] SIENTIAPDE-1478 Refactor API class to remove unnecessary blank line and improve code readability. Update test cases to rename 'timeout' parameter to 'request_timeout' for consistency. --- scouter/activities/api.py | 3 +-- tests/activities/test_api.py | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/scouter/activities/api.py b/scouter/activities/api.py index 7d2cf47..4f8e4fd 100644 --- a/scouter/activities/api.py +++ b/scouter/activities/api.py @@ -136,7 +136,6 @@ class API(SientiaMonitoring): ) raise e - latest_values['timestamp'] = latest_values['timestamp'].dt.strftime(DATETIME_FORMAT_WITH_TZ) self.debug(f'Latest values: {latest_values.to_string()}', metadata=metadata) @@ -144,7 +143,7 @@ class API(SientiaMonitoring): # Normalize the package timestamp valid_timestamp_values = latest_values['timestamp'].dropna() latest_values['timestamp'] = valid_timestamp_values.max() - + self.info(f'Gathered {len(latest_values)} tag values', metadata=metadata) return latest_values.to_dict(orient='records') diff --git a/tests/activities/test_api.py b/tests/activities/test_api.py index 8bd21e8..977cd0d 100644 --- a/tests/activities/test_api.py +++ b/tests/activities/test_api.py @@ -141,7 +141,7 @@ async def test_get_tag_values_success(api_activity): start_time='*-1d', max_count=10, metadata=metadata['metadata'], - timeout=30, + request_timeout=30, ) assert len(result) == 3 @@ -195,7 +195,7 @@ async def test_get_tag_values_with_default_max_count(api_activity): start_time='*-1h', max_count=1, metadata=metadata['metadata'], - timeout=15, + request_timeout=15, ) assert len(result) == 1