gitea_admin/sientia-dataops-scouter_temporal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SIENTIAPDE-1325

Browse Source 
Update metric labels from 'pipeline_name' to 'workflow_name' in metrics and related classes, ensuring consistency across the codebase and tests.
This commit is contained in:
vitor-aignosi
2025-11-04 08:49:38 -03:00
parent 4351289111
commit 32882d0b6f
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scouter/activities/gates.py
View File

@@ -304,7 +304,7 @@ class Gates(SientiaMonitoring):
metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels( metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels(
pod_id=self.pod_id, pod_id=self.pod_id,
model_name=metadata['model_name'], model_name=metadata['model_name'],
pipeline_name=metadata['workflow_name'], workflow_name=metadata['workflow_name'],
).inc() ).inc()
# Register metrics # Register metrics
@@ -312,7 +312,7 @@ class Gates(SientiaMonitoring):
metrics.TAG_CHANGES_MONITOR.labels( metrics.TAG_CHANGES_MONITOR.labels(
pod_id=self.pod_id, pod_id=self.pod_id,
model_name=metadata['model_name'], model_name=metadata['model_name'],
pipeline_name=metadata['workflow_name'], workflow_name=metadata['workflow_name'],
tag_name=row['variable'], tag_name=row['variable'],
).set(row['value']) ).set(row['value'])

2
scouter/metrics.py
View File

@@ -8,7 +8,7 @@ APP_UP = Gauge(
) )
# Core labels for consistent metric labeling # Core labels for consistent metric labeling
CORE_LABELS = ['pod_id', 'model_name', 'pipeline_name'] CORE_LABELS = ['pod_id', 'model_name', 'workflow_name']
# Data processing metrics # Data processing metrics
LABORIOUS_DATA_WRITTEN_COUNT = Counter( LABORIOUS_DATA_WRITTEN_COUNT = Counter(

6
tests/activities/test_gates.py
View File

@@ -390,7 +390,7 @@ async def test_write_metrics(mock_metrics, gates_fixture):
mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.assert_called_once_with( mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.assert_called_once_with(
pod_id=gates_fixture.pod_id, pod_id=gates_fixture.pod_id,
model_name=metadata['metadata']['model_name'], model_name=metadata['metadata']['model_name'],
pipeline_name=metadata['metadata']['workflow_name'], workflow_name=metadata['metadata']['workflow_name'],
) )
mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.return_value.inc.assert_called_once() mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.return_value.inc.assert_called_once()
@@ -407,13 +407,13 @@ async def test_write_metrics(mock_metrics, gates_fixture):
call( call(
pod_id=gates_fixture.pod_id, pod_id=gates_fixture.pod_id,
model_name=metadata['metadata']['model_name'], model_name=metadata['metadata']['model_name'],
pipeline_name=metadata['metadata']['workflow_name'], workflow_name=metadata['metadata']['workflow_name'],
tag_name='tag1', tag_name='tag1',
), ),
call( call(
pod_id=gates_fixture.pod_id, pod_id=gates_fixture.pod_id,
model_name=metadata['metadata']['model_name'], model_name=metadata['metadata']['model_name'],
pipeline_name=metadata['metadata']['workflow_name'], workflow_name=metadata['metadata']['workflow_name'],
tag_name='tag2', tag_name='tag2',
), ),
], ],

4
tests/test_metrics.py
View File

@@ -15,7 +15,7 @@ def test_scouter_laborious_data_written_count():
assert set(metrics.LABORIOUS_DATA_WRITTEN_COUNT._labelnames) == { assert set(metrics.LABORIOUS_DATA_WRITTEN_COUNT._labelnames) == {
'pod_id', 'pod_id',
'model_name', 'model_name',
'pipeline_name', 'workflow_name',
} }
@@ -27,6 +27,6 @@ def test_scouter_tag_changes_monitor():
assert set(metrics.TAG_CHANGES_MONITOR._labelnames) == { assert set(metrics.TAG_CHANGES_MONITOR._labelnames) == {
'pod_id', 'pod_id',
'model_name', 'model_name',
'pipeline_name', 'workflow_name',
'tag_name', 'tag_name',
} }