From 32882d0b6fc7824dcf5ab1f92b7fc2ee76a549e7 Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Tue, 4 Nov 2025 08:49:38 -0300 Subject: [PATCH] SIENTIAPDE-1325 Update metric labels from 'pipeline_name' to 'workflow_name' in metrics and related classes, ensuring consistency across the codebase and tests. --- scouter/activities/gates.py | 4 ++-- scouter/metrics.py | 2 +- tests/activities/test_gates.py | 6 +++--- tests/test_metrics.py | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/scouter/activities/gates.py b/scouter/activities/gates.py index b5ab579..0c2df2e 100644 --- a/scouter/activities/gates.py +++ b/scouter/activities/gates.py @@ -304,7 +304,7 @@ class Gates(SientiaMonitoring): metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels( pod_id=self.pod_id, model_name=metadata['model_name'], - pipeline_name=metadata['workflow_name'], + workflow_name=metadata['workflow_name'], ).inc() # Register metrics @@ -312,7 +312,7 @@ class Gates(SientiaMonitoring): metrics.TAG_CHANGES_MONITOR.labels( pod_id=self.pod_id, model_name=metadata['model_name'], - pipeline_name=metadata['workflow_name'], + workflow_name=metadata['workflow_name'], tag_name=row['variable'], ).set(row['value']) diff --git a/scouter/metrics.py b/scouter/metrics.py index ac249c7..b25fa46 100644 --- a/scouter/metrics.py +++ b/scouter/metrics.py @@ -8,7 +8,7 @@ APP_UP = Gauge( ) # Core labels for consistent metric labeling -CORE_LABELS = ['pod_id', 'model_name', 'pipeline_name'] +CORE_LABELS = ['pod_id', 'model_name', 'workflow_name'] # Data processing metrics LABORIOUS_DATA_WRITTEN_COUNT = Counter( diff --git a/tests/activities/test_gates.py b/tests/activities/test_gates.py index d02ed0a..32d173e 100644 --- a/tests/activities/test_gates.py +++ b/tests/activities/test_gates.py @@ -390,7 +390,7 @@ async def test_write_metrics(mock_metrics, gates_fixture): mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.assert_called_once_with( pod_id=gates_fixture.pod_id, model_name=metadata['metadata']['model_name'], - pipeline_name=metadata['metadata']['workflow_name'], + workflow_name=metadata['metadata']['workflow_name'], ) mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.return_value.inc.assert_called_once() @@ -407,13 +407,13 @@ async def test_write_metrics(mock_metrics, gates_fixture): call( pod_id=gates_fixture.pod_id, model_name=metadata['metadata']['model_name'], - pipeline_name=metadata['metadata']['workflow_name'], + workflow_name=metadata['metadata']['workflow_name'], tag_name='tag1', ), call( pod_id=gates_fixture.pod_id, model_name=metadata['metadata']['model_name'], - pipeline_name=metadata['metadata']['workflow_name'], + workflow_name=metadata['metadata']['workflow_name'], tag_name='tag2', ), ], diff --git a/tests/test_metrics.py b/tests/test_metrics.py index 79a96d9..be7b4f3 100644 --- a/tests/test_metrics.py +++ b/tests/test_metrics.py @@ -15,7 +15,7 @@ def test_scouter_laborious_data_written_count(): assert set(metrics.LABORIOUS_DATA_WRITTEN_COUNT._labelnames) == { 'pod_id', 'model_name', - 'pipeline_name', + 'workflow_name', } @@ -27,6 +27,6 @@ def test_scouter_tag_changes_monitor(): assert set(metrics.TAG_CHANGES_MONITOR._labelnames) == { 'pod_id', 'model_name', - 'pipeline_name', + 'workflow_name', 'tag_name', }