gitea_admin/sientia-dataops-opc-ingestor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SIENTIAPDE-1174

Browse Source 
Refactor test_init_metrics_calls_correct_metric_methods to use metrics directly instead of mock_metrics for improved clarity in test_opc_manager.py.
This commit is contained in:
vitor-aignosi
2025-08-13 15:53:10 -03:00
parent 753acf464b
commit 59f518b785
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit/managers/test_opc_manager.py
View File

@@ -543,12 +543,10 @@ def test_check_opc_listenning_error_notification_and_retry(metrics, opc_manager)
@patch("ingestor.managers.opc_manager.metrics") @patch("ingestor.managers.opc_manager.metrics")
def test_init_metrics_calls_correct_metric_methods(mock_metrics): def test_init_metrics_calls_correct_metric_methods(metrics):
mock_metrics.OPC_CONNECTION_STATUS.reset_mock()
mock_metrics.OPC_TAGS_SUBSCRIBED.reset_mock()
opc_manager = OpcManager( opc_manager = OpcManager(
name="TestConnector", name="TestInitConnector",
url="opc.tcp://init.test:4840", url="opc.tcp://init.test:4840",
data_manager=MagicMock(), data_manager=MagicMock(),
logger=MagicMock(), logger=MagicMock(),
@@ -557,19 +555,19 @@ def test_init_metrics_calls_correct_metric_methods(mock_metrics):
metadata=metadata["metadata"], metadata=metadata["metadata"],
) )
mock_metrics.OPC_CONNECTION_STATUS.labels.assert_called_with( metrics.OPC_CONNECTION_STATUS.labels.assert_called_with(
pod_id=opc_manager.pod_id, pod_id=opc_manager.pod_id,
server_name=opc_manager.name, server_name=opc_manager.name,
server_url=opc_manager.url, server_url=opc_manager.url,
) )
mock_metrics.OPC_CONNECTION_STATUS.labels.return_value.set.assert_called_once_with( metrics.OPC_CONNECTION_STATUS.labels.return_value.set.assert_called_once_with(
0) 0)
mock_metrics.OPC_TAGS_SUBSCRIBED.labels.assert_called_once_with( metrics.OPC_TAGS_SUBSCRIBED.labels.assert_called_once_with(
pod_id=opc_manager.pod_id, pod_id=opc_manager.pod_id,
server_name=opc_manager.name server_name=opc_manager.name
) )
mock_metrics.OPC_TAGS_SUBSCRIBED.labels.return_value.set.assert_called_once_with( metrics.OPC_TAGS_SUBSCRIBED.labels.return_value.set.assert_called_once_with(
0) 0)