From 59f518b7858326ed668040913abd3ecfe795f266 Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Wed, 13 Aug 2025 15:53:10 -0300 Subject: [PATCH] SIENTIAPDE-1174 Refactor test_init_metrics_calls_correct_metric_methods to use metrics directly instead of mock_metrics for improved clarity in test_opc_manager.py. --- tests/unit/managers/test_opc_manager.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/unit/managers/test_opc_manager.py b/tests/unit/managers/test_opc_manager.py index da66b24..4162c28 100644 --- a/tests/unit/managers/test_opc_manager.py +++ b/tests/unit/managers/test_opc_manager.py @@ -543,12 +543,10 @@ def test_check_opc_listenning_error_notification_and_retry(metrics, opc_manager) @patch("ingestor.managers.opc_manager.metrics") -def test_init_metrics_calls_correct_metric_methods(mock_metrics): - mock_metrics.OPC_CONNECTION_STATUS.reset_mock() - mock_metrics.OPC_TAGS_SUBSCRIBED.reset_mock() +def test_init_metrics_calls_correct_metric_methods(metrics): opc_manager = OpcManager( - name="TestConnector", + name="TestInitConnector", url="opc.tcp://init.test:4840", data_manager=MagicMock(), logger=MagicMock(), @@ -557,19 +555,19 @@ def test_init_metrics_calls_correct_metric_methods(mock_metrics): metadata=metadata["metadata"], ) - mock_metrics.OPC_CONNECTION_STATUS.labels.assert_called_with( + metrics.OPC_CONNECTION_STATUS.labels.assert_called_with( pod_id=opc_manager.pod_id, server_name=opc_manager.name, server_url=opc_manager.url, ) - mock_metrics.OPC_CONNECTION_STATUS.labels.return_value.set.assert_called_once_with( + metrics.OPC_CONNECTION_STATUS.labels.return_value.set.assert_called_once_with( 0) - mock_metrics.OPC_TAGS_SUBSCRIBED.labels.assert_called_once_with( + metrics.OPC_TAGS_SUBSCRIBED.labels.assert_called_once_with( pod_id=opc_manager.pod_id, server_name=opc_manager.name ) - mock_metrics.OPC_TAGS_SUBSCRIBED.labels.return_value.set.assert_called_once_with( + metrics.OPC_TAGS_SUBSCRIBED.labels.return_value.set.assert_called_once_with( 0)