gitea_admin/sientia-dataops-opc-ingestor
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

SIENTIAPDE-1974: chore(slots): drop NOSONAR, accept S7504 in SonarQube instead

Browse Source 
Review (Vitor): avoid NOSONAR; when a SonarQube issue does not apply, accept it
in SonarQube so the decision is recorded there. The list() snapshot of the
readers stays (the loop awaits) and the comment says why S7504 is accepted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Eduardo Rios
2026-10-13 13:24:54 -03:00
parent dba5300379
commit 06caa88ed8
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ingestor/managers/ingestor_manager.py
View File

@@ -561,8 +561,9 @@ class IngestorManager(SientiaMonitoring):
""" """
# list() snapshots the readers: the loop awaits, so a reader added or removed # list() snapshots the readers: the loop awaits, so a reader added or removed
# meanwhile must not break the iteration. # meanwhile must not break the iteration. SonarQube flags it as an unnecessary
for server, reader in list(self.opc_managers.items()): # NOSONAR # list() (S7504); the issue is accepted in SonarQube for this reason.
for server, reader in list(self.opc_managers.items()):
if slot in reader.subscriptions: if slot in reader.subscriptions:
await self._unsubscribe_reader(server, reader, slot) await self._unsubscribe_reader(server, reader, slot)