From 06caa88ed81f812fb74d6cf0408399c7e530ec48 Mon Sep 17 00:00:00 2001 From: Eduardo Rios Date: Tue, 13 Oct 2026 13:24:54 -0300 Subject: [PATCH] SIENTIAPDE-1974: chore(slots): drop NOSONAR, accept S7504 in SonarQube instead Review (Vitor): avoid NOSONAR; when a SonarQube issue does not apply, accept it in SonarQube so the decision is recorded there. The list() snapshot of the readers stays (the loop awaits) and the comment says why S7504 is accepted. Co-Authored-By: Claude Opus 5.5 --- ingestor/managers/ingestor_manager.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ingestor/managers/ingestor_manager.py b/ingestor/managers/ingestor_manager.py index a141e3c..4b3d8f8 100644 --- a/ingestor/managers/ingestor_manager.py +++ b/ingestor/managers/ingestor_manager.py @@ -561,8 +561,9 @@ class IngestorManager(SientiaMonitoring): """ # list() snapshots the readers: the loop awaits, so a reader added or removed - # meanwhile must not break the iteration. - for server, reader in list(self.opc_managers.items()): # NOSONAR + # meanwhile must not break the iteration. SonarQube flags it as an unnecessary + # list() (S7504); the issue is accepted in SonarQube for this reason. + for server, reader in list(self.opc_managers.items()): if slot in reader.subscriptions: await self._unsubscribe_reader(server, reader, slot)