SIENTIAPDE-1252: Remove experiment_description from TrainModelParams and related tests.

This commit is contained in:
Bruno Domingues
2025-10-09 17:48:43 -03:00
parent 5b0cd92dfe
commit 94e11df803
5 changed files with 5 additions and 24 deletions

View File

@@ -26,8 +26,7 @@ def valid_params_dict():
'train_size': 80,
'shuffle': True,
'experiment_run_id': 123,
'experiment_name': 'test-experiment',
'experiment_description': 'Test experiment description',
'experiment_name': 'Test experiment name',
'removed_intervals': [],
}
@@ -53,8 +52,7 @@ def test_train_model_params_creation_with_valid_params(valid_params_dict):
assert params.train_size == 80
assert params.shuffle is True
assert params.experiment_run_id == 123
assert params.experiment_name == 'test-experiment'
assert params.experiment_description == 'Test experiment description'
assert params.experiment_name == 'Test experiment name'
assert params.removed_intervals == []
@@ -201,13 +199,13 @@ def test_train_model_params_removed_intervals_with_values(valid_params_dict):
def test_train_model_params_all_fields_count():
"""Test that TrainModelParams has exactly 20 required fields."""
"""Test that TrainModelParams has exactly 19 required fields."""
import inspect
sig = inspect.signature(TrainModelParams.__init__)
# Subtract 1 for 'self'
param_count = len(sig.parameters) - 1
assert param_count == 20
assert param_count == 19
def test_train_model_params_with_minimal_valid_data():
@@ -230,8 +228,7 @@ def test_train_model_params_with_minimal_valid_data():
train_size=50,
shuffle=False,
experiment_run_id=1,
experiment_name='exp',
experiment_description='desc',
experiment_name='name',
removed_intervals=[],
)
@@ -261,7 +258,6 @@ def test_train_model_params_check_none_method():
'shuffle': True,
'experiment_run_id': 123,
'experiment_name': 'exp',
'experiment_description': 'desc',
'removed_intervals': [],
}
@@ -293,7 +289,6 @@ def test_train_model_params_check_type_method():
'shuffle': True,
'experiment_run_id': 123,
'experiment_name': 'exp',
'experiment_description': 'desc',
'removed_intervals': [],
}

View File

@@ -31,7 +31,6 @@ def sample_params():
shuffle=True,
experiment_run_id=123,
experiment_name='test-experiment',
experiment_description='Test experiment description',
removed_intervals=[],
)