diff --git a/model_manager/utils/models/train_model_params.py b/model_manager/utils/models/train_model_params.py index 251e252..af1b1c7 100644 --- a/model_manager/utils/models/train_model_params.py +++ b/model_manager/utils/models/train_model_params.py @@ -34,7 +34,6 @@ class TrainModelParams: shuffle (bool): Whether to shuffle the data during train/test split. experiment_run_id (int): Unique identifier for the experiment run. experiment_name (str): Name of the experiment for tracking. - experiment_description (str): Description of the experiment. removed_intervals (list): List of time intervals to remove from the data. """ @@ -56,7 +55,6 @@ class TrainModelParams: shuffle: bool experiment_run_id: int experiment_name: str - experiment_description: str removed_intervals: list @classmethod @@ -114,9 +112,6 @@ class TrainModelParams: data.get('experiment_run_id'), int, 'experiment_run_id' ), experiment_name=cls._check_none(data.get('experiment_name'), str, 'experiment_name'), - experiment_description=cls._check_none( - data.get('experiment_description'), str, 'experiment_description' - ), removed_intervals=cls._check_type( data.get('removed_intervals'), list, 'removed_intervals' ), diff --git a/tests/activities/test_training.py b/tests/activities/test_training.py index 4c51c3e..9616ee1 100644 --- a/tests/activities/test_training.py +++ b/tests/activities/test_training.py @@ -61,7 +61,6 @@ async def test_train_model_success(mock_training_repository_class): 'upp_lim': {'feature1': 100.0, 'feature2': 100.0}, 'window': 10, 'experiment_name': 'test_experiment', - 'experiment_description': 'Test experiment', 'removed_intervals': [], } @@ -118,7 +117,6 @@ async def test_train_model_invalid_file_type(mock_training_repository_class): 'upp_lim': {'feature1': 100.0}, 'window': 10, 'experiment_name': 'test_experiment', - 'experiment_description': 'Test experiment', 'removed_intervals': [], }, } @@ -169,7 +167,6 @@ async def test_train_model_training_error(mock_training_repository_class): 'upp_lim': {'feature1': 100.0}, 'window': 10, 'experiment_name': 'test_experiment', - 'experiment_description': 'Test experiment', 'removed_intervals': [], }, } @@ -219,7 +216,6 @@ async def test_train_model_sends_notification_on_error(mock_training_repository_ 'upp_lim': {'feature1': 100.0}, 'window': 10, 'experiment_name': 'test_experiment', - 'experiment_description': 'Test experiment', 'removed_intervals': [], }, } @@ -274,7 +270,6 @@ async def test_train_model_after_calculation_error(mock_training_repository_clas 'upp_lim': {'feature1': 100.0}, 'window': 10, 'experiment_name': 'test_experiment', - 'experiment_description': 'Test experiment', 'removed_intervals': [], }, } diff --git a/tests/utils/models/test_train_model_params.py b/tests/utils/models/test_train_model_params.py index 9622fc5..f71a4af 100644 --- a/tests/utils/models/test_train_model_params.py +++ b/tests/utils/models/test_train_model_params.py @@ -26,8 +26,7 @@ def valid_params_dict(): 'train_size': 80, 'shuffle': True, 'experiment_run_id': 123, - 'experiment_name': 'test-experiment', - 'experiment_description': 'Test experiment description', + 'experiment_name': 'Test experiment name', 'removed_intervals': [], } @@ -53,8 +52,7 @@ def test_train_model_params_creation_with_valid_params(valid_params_dict): assert params.train_size == 80 assert params.shuffle is True assert params.experiment_run_id == 123 - assert params.experiment_name == 'test-experiment' - assert params.experiment_description == 'Test experiment description' + assert params.experiment_name == 'Test experiment name' assert params.removed_intervals == [] @@ -201,13 +199,13 @@ def test_train_model_params_removed_intervals_with_values(valid_params_dict): def test_train_model_params_all_fields_count(): - """Test that TrainModelParams has exactly 20 required fields.""" + """Test that TrainModelParams has exactly 19 required fields.""" import inspect sig = inspect.signature(TrainModelParams.__init__) # Subtract 1 for 'self' param_count = len(sig.parameters) - 1 - assert param_count == 20 + assert param_count == 19 def test_train_model_params_with_minimal_valid_data(): @@ -230,8 +228,7 @@ def test_train_model_params_with_minimal_valid_data(): train_size=50, shuffle=False, experiment_run_id=1, - experiment_name='exp', - experiment_description='desc', + experiment_name='name', removed_intervals=[], ) @@ -261,7 +258,6 @@ def test_train_model_params_check_none_method(): 'shuffle': True, 'experiment_run_id': 123, 'experiment_name': 'exp', - 'experiment_description': 'desc', 'removed_intervals': [], } @@ -293,7 +289,6 @@ def test_train_model_params_check_type_method(): 'shuffle': True, 'experiment_run_id': 123, 'experiment_name': 'exp', - 'experiment_description': 'desc', 'removed_intervals': [], } diff --git a/tests/utils/models/test_train_model_result.py b/tests/utils/models/test_train_model_result.py index 8ec77b4..0ba7912 100644 --- a/tests/utils/models/test_train_model_result.py +++ b/tests/utils/models/test_train_model_result.py @@ -31,7 +31,6 @@ def sample_params(): shuffle=True, experiment_run_id=123, experiment_name='test-experiment', - experiment_description='Test experiment description', removed_intervals=[], ) diff --git a/tests/utils/repository/test_training_repository.py b/tests/utils/repository/test_training_repository.py index fcd90f8..f60e826 100644 --- a/tests/utils/repository/test_training_repository.py +++ b/tests/utils/repository/test_training_repository.py @@ -46,7 +46,6 @@ def train_params(): shuffle=True, experiment_run_id=123, experiment_name='test_experiment', - experiment_description='Test experiment', removed_intervals=[], ) @@ -200,7 +199,6 @@ def test_init_scaler_dict_without_scaler(training_repository): shuffle=True, experiment_run_id=123, experiment_name='test', - experiment_description='test', removed_intervals=[], ) @@ -281,7 +279,6 @@ def test_after_train_calculation_without_scaler(mock_r2, mock_mae, mock_mse, tra shuffle=True, experiment_run_id=123, experiment_name='test', - experiment_description='test', removed_intervals=[], )