SIENTIAPDE-1441

SIENTIAPDE-1441: Refactor worker configuration in worker.py to utilize a new prepare_worker function for cleaner setup. Update environment variable names in values.yaml for consistency and clarity, adjusting memory requests and enhancing health check commands for improved application monitoring.

values.yaml

@@ -69,7 +69,7 @@ resources:
     memory: 2048Mi
   requests:
     cpu: 300m
-    memory: 512Mi
+    memory: 256Mi
 
 # This is to setup the liveness and readiness probes more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
 livenessProbe:
@@ -78,12 +78,7 @@ livenessProbe:
       - sh
       - -c
       - |
-        APP_UP=$(curl -s http://localhost:9090/metrics | grep '^app_up{' | grep -o '[0-9]' | head -1)
-        if [ "$APP_UP" = "1" ]; then
-          exit 0
-        else
-          exit 1
-        fi
+        curl -sf http://localhost:9090/metrics | grep -q '^app_up{.*} 1'
   initialDelaySeconds: 30
   periodSeconds: 15
   timeoutSeconds: 5
@@ -95,12 +90,7 @@ readinessProbe:
       - sh
       - -c
       - |
-        APP_UP=$(curl -s http://localhost:9090/metrics | grep '^app_up{' | grep -o '[0-9]' | head -1)
-        if [ "$APP_UP" = "1" ]; then
-          exit 0
-        else
-          exit 1
-        fi
+        curl -sf http://localhost:9090/metrics | grep -q '^app_up{.*} 1'
   initialDelaySeconds: 20
   periodSeconds: 10
   timeoutSeconds: 3
@@ -233,27 +223,27 @@ env:
     value: "http://library-distribution-server.library.svc.cluster.local:5000"
 
   # Temporal worker tuning
-  - name: MAX_CONCURRENT_WORKFLOW_TASKS
+  - name: SCOUTER_MAX_CONCURRENT_WORKFLOW_TASKS
     value: "200"
-  - name: MAX_CONCURRENT_ACTIVITIES
+  - name: SCOUTER_MAX_CONCURRENT_ACTIVITIES
     value: "200"
-  - name: MAX_CONCURRENT_LOCAL_ACTIVITIES
+  - name: SCOUTER_MAX_CONCURRENT_LOCAL_ACTIVITIES
     value: "200"
-  - name: MAX_CACHED_WORKFLOWS
+  - name: SCOUTER_MAX_CACHED_WORKFLOWS
     value: "200"
 
-  - name: WORKFLOW_POLLER_BEHAVIUR_MINIMUM
+  - name: SCOUTER_WORKFLOW_POLLER_BEHAVIUR_MINIMUM
     value: "10"
-  - name: WORKFLOW_POLLER_BEHAVIUR_INITIAL
+  - name: SCOUTER_WORKFLOW_POLLER_BEHAVIUR_INITIAL
     value: "100"
-  - name: WORKFLOW_POLLER_BEHAVIUR_MAXIMUM
+  - name: SCOUTER_WORKFLOW_POLLER_BEHAVIUR_MAXIMUM
     value: "200"
 
-  - name: ACTIVITY_POLLER_BEHAVIUR_MINIMUM
+  - name: SCOUTER_ACTIVITY_POLLER_BEHAVIUR_MINIMUM
     value: "10"
-  - name: ACTIVITY_POLLER_BEHAVIUR_INITIAL
+  - name: SCOUTER_ACTIVITY_POLLER_BEHAVIUR_INITIAL
     value: "100"
-  - name: ACTIVITY_POLLER_BEHAVIUR_MAXIMUM
+  - name: SCOUTER_ACTIVITY_POLLER_BEHAVIUR_MAXIMUM
     value: "200"