gitea_admin/sientia-dataops-scouter_temporal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SIENTIAPDE-1273

Browse Source 
Update GITHUB_BRANCH in values.yaml to feature/SIENTIAPDE-1273, increment Helm chart version to 0.6.0, and modify metrics registration in Gates class to skip None values. Update test cases to reflect changes in tag values.
This commit is contained in:
vitor-aignosi
2025-11-14 12:04:16 -03:00
parent 5db04c7e5b
commit 6701a25c7b
3 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
scouter/activities/gates.py
View File

@@ -309,11 +309,13 @@ class Gates(SientiaMonitoring):
# Register metrics # Register metrics
for _, row in tag_values.iterrows(): for _, row in tag_values.iterrows():
metrics.TAG_CHANGES_MONITOR.labels( value = row['value']
pod_id=self.pod_id, if value is not None:
model_name=metadata['model_name'], metrics.TAG_CHANGES_MONITOR.labels(
workflow_name=metadata['workflow_name'], pod_id=self.pod_id,
tag_name=row['variable'], model_name=metadata['model_name'],
).set(row['value']) workflow_name=metadata['workflow_name'],
tag_name=row['variable'],
).set(row['value'])
self.info(f'Metrics written for {metadata["model_name"]}', metadata=metadata) self.info(f'Metrics written for {metadata["model_name"]}', metadata=metadata)

5
tests/activities/test_gates.py
View File

@@ -382,8 +382,8 @@ async def test_write_metrics(mock_metrics, gates_fixture):
input_data = { input_data = {
'metadata': metadata['metadata'], 'metadata': metadata['metadata'],
'tag_values': { 'tag_values': {
'variable': ['tag1', 'tag2'], 'variable': ['tag1', 'tag2', 'tag3'],
'value': [1.0, 2.0], 'value': [1.0, 2.0, None],
}, },
} }
await gates_fixture.write_metrics(input_data) await gates_fixture.write_metrics(input_data)
@@ -394,6 +394,7 @@ async def test_write_metrics(mock_metrics, gates_fixture):
) )
mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.return_value.inc.assert_called_once() mock_metrics.LABORIOUS_DATA_WRITTEN_COUNT.labels.return_value.inc.assert_called_once()
# Only tags with None values should be registered
mock_metrics.TAG_CHANGES_MONITOR.labels.return_value.set.assert_has_calls( mock_metrics.TAG_CHANGES_MONITOR.labels.return_value.set.assert_has_calls(
[ [
call(1.0), call(1.0),

4
values.yaml
View File

@@ -150,7 +150,7 @@ env:
- name: GITHUB_REPO_URL - name: GITHUB_REPO_URL
value: "git@github.com:Aignosi/sientia-dataops-scouter_temporal.git" value: "git@github.com:Aignosi/sientia-dataops-scouter_temporal.git"
- name: GITHUB_BRANCH - name: GITHUB_BRANCH
value: "feature/SIENTIAPDE-1325-adicionar-metricas-especificas-de-operacoes-externas" value: "feature/SIENTIAPDE-1273"
- name: PYTHON_APP - name: PYTHON_APP
value: "scouter.worker.worker" value: "scouter.worker.worker"
@@ -219,7 +219,7 @@ ssh:
# kubectl create secret docker-registry docker-hub-secret --namespace sientia --docker-server=http://aignosi.azurecr.io --docker-username=aignosi --docker-password=5I5zpQ6sRaHqX1hD3dr+2mo647yO3FRc359/wu6gsP+ACRDRz5mp # kubectl create secret docker-registry docker-hub-secret --namespace sientia --docker-server=http://aignosi.azurecr.io --docker-username=aignosi --docker-password=5I5zpQ6sRaHqX1hD3dr+2mo647yO3FRc359/wu6gsP+ACRDRz5mp
# helm upgrade --install sientia-scouter-worker sientia/sientia-module -n sientia --create-namespace -f ./values.yaml --version 0.5.0 # helm upgrade --install sientia-scouter-worker sientia/sientia-module -n sientia --create-namespace -f ./values.yaml --version 0.6.0
# kubectl create secret generic git-ssh-key-sientia-scouter-worker \ # kubectl create secret generic git-ssh-key-sientia-scouter-worker \
# --namespace sientia \ # --namespace sientia \