From 034e0b2520f386b4e3518c9d95b56b9c4d8626a3 Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Wed, 17 Dec 2025 16:46:15 -0300 Subject: [PATCH] SIENTIAPDE-1445 Refactor workflow parameters in tests.ipynb and prepare_worker.py to enhance clarity and flexibility. Updated workflow_id and task_queue to accept dynamic values, and standardized timeout parameters for improved configuration. --- scouter/worker/prepare_worker.py | 4 +++- tests.ipynb | 10 +++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/scouter/worker/prepare_worker.py b/scouter/worker/prepare_worker.py index 09fced1..df58d0e 100644 --- a/scouter/worker/prepare_worker.py +++ b/scouter/worker/prepare_worker.py @@ -27,6 +27,8 @@ def prepare_worker( ) -> Worker: main_workflow_name = main_workflow.__name__.upper() + queue_name = f'{main_workflow_name.lower().replace("_", "-")}-queue' + local_workflow_parameters = {} for parameter in parameters: @@ -36,7 +38,7 @@ def prepare_worker( return Worker( temporal_client, - task_queue='scouter-queue', + task_queue=queue_name, workflows=[main_workflow, *other_workflows], activities=[*activities], max_concurrent_workflow_tasks=local_workflow_parameters['MAX_CONCURRENT_WORKFLOW_TASKS'], diff --git a/tests.ipynb b/tests.ipynb index 607f5ad..7a64d24 100644 --- a/tests.ipynb +++ b/tests.ipynb @@ -17,8 +17,8 @@ " temporal_client: client.Client,\n", " workflow_name: str,\n", " workflow_input: dict[str, Any],\n", - " workflow_id: str | None = None,\n", - " task_queue: str = \"scouter-queue\",\n", + " workflow_id: str,\n", + " task_queue: str,\n", " execution_timeout: timedelta | None = None,\n", " run_timeout: timedelta | None = None,\n", " task_timeout: timedelta | None = None,\n", @@ -116,7 +116,11 @@ " temporal_client=temporal_client,\n", " workflow_name='pi_web_api_scouter',\n", " workflow_input=input_data,\n", - " workflow_id='test_workflow_id_' + now.strftime('%Y%m%d%H%M%S')\n", + " workflow_id='test_workflow_id_' + now.strftime('%Y%m%d%H%M%S'),\n", + " task_queue='pi-web-api-scouter-queue',\n", + " execution_timeout=timedelta(seconds=30),\n", + " run_timeout=timedelta(seconds=30),\n", + " task_timeout=timedelta(seconds=30),\n", ")\n", "\n" ]