gitea_admin/sientia-dataops-orchestrator_temporal
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: annotate already_added_keys to satisfy mypy

Browse Source 
The parameter-level annotation on _check_keys_and_notif_id alone
wasn't enough -- mypy needs the type at the empty list's declaration
site inside filter_notification_alerts. Also reformatted the helper's
now-longer signature to satisfy ruff.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Eduardo Rios
2026-09-15 14:51:51 -03:00
parent a59cc1c691
commit 081298a883
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
orchestrator/activities/slot_manager.py
View File

@@ -420,7 +420,7 @@ class SlotManager(SientiaMonitoring):
receiver_groups[group_name] = {**receiver_group, 'notifications': []} receiver_groups[group_name] = {**receiver_group, 'notifications': []}
receiver_groups[group_name]['notifications'] = [] receiver_groups[group_name]['notifications'] = []
already_added_keys = [] already_added_keys: list[str] = []
ignore_list = receiver_group.get('ignore', []) ignore_list = receiver_group.get('ignore', [])
levels_list = receiver_group.get('levels') levels_list = receiver_group.get('levels')
@@ -486,7 +486,9 @@ class SlotManager(SientiaMonitoring):
return level_check and model_id_check return level_check and model_id_check
@staticmethod @staticmethod
def _check_keys_and_notif_id(notification_id, ignore_list, key, already_added_keys) -> bool: def _check_keys_and_notif_id(
notification_id, ignore_list, key, already_added_keys: list[str]
) -> bool:
""" """
Check if the key has already been added to the list of already added keys. Check if the key has already been added to the list of already added keys.