fix(gateway): suppress SonarQube S7504 false positive in close_all
list() here isn't redundant: _evict() pops from self._connections, so iterating the dict directly would raise 'changed size during iteration'. NOSONAR + comment explaining why, per Sonar's own suppression convention already used in ingestor/app.py.
This commit is contained in:
@@ -107,7 +107,9 @@ class OpcConnectionPool(SientiaMonitoring):
|
||||
|
||||
async def close_all(self):
|
||||
"""Disconnect every pooled client (e.g. on shutdown)."""
|
||||
for server_id in list(self._connections):
|
||||
# list() snapshots the keys: _evict() pops from self._connections,
|
||||
# so iterating the dict directly would raise "changed size during iteration".
|
||||
for server_id in list(self._connections): # NOSONAR
|
||||
await self._evict(server_id)
|
||||
|
||||
async def _evict(self, server_id: str):
|
||||
|
||||
Reference in New Issue
Block a user