gitea_admin/sientia-dataops-opc-ingestor
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(gateway): suppress SonarQube S7504 false positive in close_all

Browse Source 
list() here isn't redundant: _evict() pops from self._connections, so
iterating the dict directly would raise 'changed size during iteration'.
NOSONAR + comment explaining why, per Sonar's own suppression convention
already used in ingestor/app.py.
This commit is contained in:
PedroHMCosme
2026-09-22 12:03:21 -03:00
parent cfa8078334
commit e76df05e7a
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ingestor/connection/pool.py
View File

@@ -107,7 +107,9 @@ class OpcConnectionPool(SientiaMonitoring):
async def close_all(self): async def close_all(self):
"""Disconnect every pooled client (e.g. on shutdown).""" """Disconnect every pooled client (e.g. on shutdown)."""
for server_id in list(self._connections): # list() snapshots the keys: _evict() pops from self._connections,
# so iterating the dict directly would raise "changed size during iteration".
for server_id in list(self._connections): # NOSONAR
await self._evict(server_id) await self._evict(server_id)
async def _evict(self, server_id: str): async def _evict(self, server_id: str):