From 810bf54d5675779ad03096ac245cede590d04bbe Mon Sep 17 00:00:00 2001 From: Bruno Domingues Date: Wed, 5 Aug 2026 15:25:06 -0300 Subject: [PATCH] fix(ingestor): Remove __del__ methods for async shutdown --- ingestor/managers/ingestor_manager.py | 4 ---- ingestor/managers/opc_manager.py | 3 --- tests/unit/managers/test_ingestor_manager.py | 7 ------- 3 files changed, 14 deletions(-) diff --git a/ingestor/managers/ingestor_manager.py b/ingestor/managers/ingestor_manager.py index 34a09ca..0034d0a 100644 --- a/ingestor/managers/ingestor_manager.py +++ b/ingestor/managers/ingestor_manager.py @@ -1,4 +1,3 @@ -import asyncio import traceback from copy import deepcopy @@ -188,9 +187,6 @@ class IngestorManager(SientiaMonitoring): await server.shutdown() self.data_manager.shutdown() - def __del__(self): - asyncio.run(self.shutdown()) - async def remove_server(self, server: str): """ Removes an OPC server from the ingestor. diff --git a/ingestor/managers/opc_manager.py b/ingestor/managers/opc_manager.py index 3505757..c08d5ab 100644 --- a/ingestor/managers/opc_manager.py +++ b/ingestor/managers/opc_manager.py @@ -112,9 +112,6 @@ class OpcManager(SientiaMonitoring): f'nodes={self.nodes}, subscriptions={self.subscriptions}' ) - def __del__(self): - asyncio.run(self.shutdown()) - async def shutdown(self): """ Comprehensive cleanup method for graceful shutdown. diff --git a/tests/unit/managers/test_ingestor_manager.py b/tests/unit/managers/test_ingestor_manager.py index 9dcdd21..fe8308c 100644 --- a/tests/unit/managers/test_ingestor_manager.py +++ b/tests/unit/managers/test_ingestor_manager.py @@ -170,13 +170,6 @@ async def test_shutdown(ingestor_manager): ingestor_manager.data_manager.shutdown.assert_called_once() -@patch('ingestor.managers.ingestor_manager.asyncio') -def test___del__(asyncio_mock, ingestor_manager): - ingestor_manager.shutdown = MagicMock() - ingestor_manager.__del__() - asyncio_mock.run.assert_called_once_with(ingestor_manager.shutdown.return_value) - - @mark.asyncio async def test_remove_server(ingestor_manager): server1 = AsyncMock()