From 2de4c4917ff177ecb3ea102aedceb3220a7ffc7e Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Tue, 5 Aug 2025 14:01:51 -0300 Subject: [PATCH] SIENTIAPDE-1174 Refactor test assertions in test_opc_manager.py for improved readability - Updated the assertion syntax for notification calls in the test_check_opc_listenning_error_notification_and_retry function to use dictionary literals for clarity. --- tests/unit/managers/test_opc_manager.py | 28 ++++++++++++------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tests/unit/managers/test_opc_manager.py b/tests/unit/managers/test_opc_manager.py index 5774544..f82d065 100644 --- a/tests/unit/managers/test_opc_manager.py +++ b/tests/unit/managers/test_opc_manager.py @@ -511,21 +511,21 @@ def test_check_opc_listenning_error_notification_and_retry(metrics, opc_manager) assert opc_manager.send_notification.call_count == 2 calls = opc_manager.send_notification.call_args_list # First call: 5 cycles warning - assert calls[0].kwargs == dict( - notification_id=f"OPC_LISTENNING_STOPPED__{opc_manager.name}", - message=f"15 cycles without receive from OPC {opc_manager.name}. Tags: {json.dumps(opc_manager.nodes)}", - block="opc_manager", - level=NotificationLevel.ERROR, - metadata=metadata["metadata"], - ) + assert calls[0].kwargs == { + "notification_id": f"OPC_LISTENNING_STOPPED__{opc_manager.name}", + "message": f"15 cycles without receive from OPC {opc_manager.name}. Tags: {json.dumps(opc_manager.nodes)}", + "block": "opc_manager", + "level": NotificationLevel.ERROR, + "metadata": metadata["metadata"], + } # Second call: 15 cycles retry - assert calls[1].kwargs == dict( - notification_id=f"OPC_CONNECTION_RETRY__{opc_manager.name}", - message=f"Retrying to connect to server {opc_manager.name}", - block="opc_manager", - level=NotificationLevel.ERROR, - metadata=metadata["metadata"], - ) + assert calls[1].kwargs == { + "notification_id": f"OPC_CONNECTION_RETRY__{opc_manager.name}", + "message": f"Retrying to connect to server {opc_manager.name}", + "block": "opc_manager", + "level": NotificationLevel.ERROR, + "metadata": metadata["metadata"], + } assert result is True metrics.OPC_CYCLES_WITHOUT_DATA.labels.assert_called_once_with(