Merge branch 'feature/SIENTIAPDE-1972-gateway-write-read' into feature/SIENTIAPDE-1972-gateway-wiring

ingestor/adapters/grpc_server.py

@@ -53,7 +53,7 @@ class GrpcServer:
         self.logger = logger
         self.port = port
         self.slot_lookup = slot_lookup
-        self.server = None
+        self.server: grpc.aio.Server | None = None
 
     async def start(self) -> None:
         self.server = grpc.aio.server()

ingestor/adapters/nats_consumer.py

@@ -9,6 +9,8 @@ here. No reconnect logic — nats-py handles reconnection internally.
 import json
 
 import nats
+from nats.aio.client import Client
+from nats.aio.subscription import Subscription
 from sientia_do.observability.logger import Logger
 
 from ingestor.engines.write import WriteEngine
@@ -28,8 +30,8 @@ class NatsWriteConsumer:
         self.logger = logger
         self.subject = subject
         self.queue = queue
-        self.nc = None
+        self.nc: Client | None = None
-        self.sub = None
+        self.sub: Subscription | None = None
 
     async def start(self) -> None:
         self.nc = await nats.connect(servers=self.nats_url)

ingestor/connection/pool.py

@@ -75,7 +75,9 @@ class OpcConnectionPool(SientiaMonitoring):
 
     async def _connect(self, server_cfg: dict) -> Client:
         client = Client(server_cfg['url'], timeout=10)
-        client.application_uri = server_cfg.get('server_uri')
+        server_uri = server_cfg.get('server_uri')
+        if server_uri:
+            client.application_uri = server_uri
         if server_cfg.get('use_security'):
             cert, key = await self.cert_provider.fetch()
             await apply_security(client, server_cfg.get('server_uri'), cert, key, None)

ingestor/engines/active_read.py

@@ -75,7 +75,7 @@ class ActiveReadEngine(SientiaMonitoring):
         await self._record_read_lag(source_ts, tags)
         source_str = self._format_ts(source_ts)
         persisted = bool(names)
-        if persisted:
+        if names:
             await self.sink.publish_reading(
                 tag=addr, value=value, timestamp=source_str, names=names
             )

pyproject.toml

@@ -81,6 +81,9 @@ warn_unused_ignores = false
 warn_no_return = true
 strict_equality = true
 ignore_missing_imports = true
+# Generated protoc/grpcio-tools output - not a checking target, dynamic attrs
+# mypy can't see (message classes built at runtime from DESCRIPTOR).
+exclude = ["^ingestor/proto/"]
 
 # Ignore missing imports for external packages
 [[tool.mypy.overrides]]
@@ -107,6 +110,14 @@ ignore_missing_imports = true
 module = "pandas.*"
 ignore_missing_imports = true
 
+# Generated protoc/grpcio-tools output - not hand-maintained, dynamic attrs
+# mypy can't see (message classes built at runtime from DESCRIPTOR). Skip
+# following it entirely so importers see Any instead of false attr-defined errors.
+[[tool.mypy.overrides]]
+module = "ingestor.proto.*"
+ignore_errors = true
+follow_imports = "skip"
+
 [tool.pytest.ini_options]
 testpaths = ["tests"]
 python_files = ["test_*.py"]