SIENTIAPDE-1430: Refactor static threshold calculation logic and enhance test coverage

model_manager/utils/repository/training_repository.py

@@ -242,6 +242,20 @@ class TrainingRepository:
 
         return scaler_dict
 
+    def _get_static_threshold(self, params: TrainModelParams) -> int | None:
+        """
+        Get the static threshold value based on parameters.
+
+        Args:
+            params: Training parameters containing static window configuration
+
+        Returns:
+            int | None: Static threshold value (1-1000) if rem_static_win is True, None otherwise
+        """
+        if not params.rem_static_win:
+            return None
+        return params.static_threshold if params.static_threshold is not None else 1
+
     def _init_data_preprocessor(self, params: TrainModelParams) -> DataPreprocessor:
         """
         Initialize DataPreprocessor with training parameters.
@@ -269,9 +283,7 @@ class TrainingRepository:
             start_date=params.start_date,
             end_date=params.end_date,
             removed_intervals=removed_intervals,
-            static_threshold=(params.static_threshold if params.static_threshold is not None else 1)
-            if params.rem_static_win
-            else None,
+            static_threshold=self._get_static_threshold(params),
             low_lim=params.low_lim,
             upp_lim=params.upp_lim,
             scaler_name=params.scaler_name,