SIENTIAPDE-1307: Integrate metrics controller and update sientia-dataops-library to 1.5.1. This change adds metrics collection capabilities to activities and updates the dataops library dependency. (18 files changed, 143 insertions(+), 16 deletions(-))

2025-10-31 17:06:26 -03:00
parent 326f9f9dc6
commit db581f60f9
6 changed files with 102 additions and 44 deletions
--- a/tests/activities/test_experiment_tracking.py
+++ b/tests/activities/test_experiment_tracking.py
@@ -18,6 +18,12 @@ def mock_notification_handler():
    return MagicMock()


+@pytest.fixture
+def mock_metrics_controller():
+    """Create a mock metrics controller."""
+    return MagicMock()
+
+
@pytest.fixture
 def db_config():
    """Create a valid database configuration."""
@@ -34,7 +40,7 @@ def db_config():

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_experiment_tracking_init(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test ExperimentTracking initialization."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -49,6 +55,7 @@ def test_experiment_tracking_init(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    mock_postgres_init.assert_called_once_with(
@@ -61,12 +68,13 @@ def test_experiment_tracking_init(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )


@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_experiment_tracking_del_without_engine(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test __del__ when engine attribute does not exist."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -81,6 +89,7 @@ def test_experiment_tracking_del_without_engine(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    if hasattr(et, 'engine'):
@@ -91,7 +100,7 @@ def test_experiment_tracking_del_without_engine(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_experiment_tracking_del_with_engine(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test __del__ when engine exists."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -106,6 +115,7 @@ def test_experiment_tracking_del_with_engine(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.engine = MagicMock()
@@ -120,7 +130,7 @@ def test_experiment_tracking_del_with_engine(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_experiment_tracking_del_with_engine_exception(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test __del__ catches exceptions."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -135,6 +145,7 @@ def test_experiment_tracking_del_with_engine_exception(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.engine = MagicMock()
@@ -154,7 +165,7 @@ def test_experiment_tracking_del_with_engine_exception(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_execute_update_success(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test _execute_update executes query successfully."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -169,6 +180,7 @@ def test_execute_update_success(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    mock_connection = MagicMock()
@@ -187,7 +199,7 @@ def test_execute_update_success(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_status_success(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with STATUS update type."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -202,6 +214,7 @@ def test_update_experiment_run_status_success(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    mock_execute = MagicMock()
@@ -232,7 +245,7 @@ def test_update_experiment_run_status_success(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_status_missing_status(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with STATUS but missing status parameter."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -247,6 +260,7 @@ def test_update_experiment_run_status_missing_status(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.send_notification = MagicMock()
@@ -265,7 +279,7 @@ def test_update_experiment_run_status_missing_status(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_status_with_error_success(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with STATUS_WITH_ERROR update type."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -280,6 +294,7 @@ def test_update_experiment_run_status_with_error_success(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    mock_execute = MagicMock()
@@ -311,7 +326,7 @@ def test_update_experiment_run_status_with_error_success(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_status_with_error_truncate_message(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run truncates error message if too long."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -326,6 +341,7 @@ def test_update_experiment_run_status_with_error_truncate_message(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    mock_execute = MagicMock()
@@ -354,7 +370,7 @@ def test_update_experiment_run_status_with_error_truncate_message(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_status_with_error_missing_error_message(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with STATUS_WITH_ERROR but missing error_message."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -369,6 +385,7 @@ def test_update_experiment_run_status_with_error_missing_error_message(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.send_notification = MagicMock()
@@ -388,7 +405,7 @@ def test_update_experiment_run_status_with_error_missing_error_message(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_model_saved_success(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with MODEL_SAVED update type."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -403,6 +420,7 @@ def test_update_experiment_run_model_saved_success(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    mock_execute = MagicMock()
@@ -434,7 +452,7 @@ def test_update_experiment_run_model_saved_success(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_model_saved_missing_run_name(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with MODEL_SAVED but missing run_name."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -449,6 +467,7 @@ def test_update_experiment_run_model_saved_missing_run_name(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.send_notification = MagicMock()
@@ -468,7 +487,7 @@ def test_update_experiment_run_model_saved_missing_run_name(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_invalid_update_type(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with invalid update_type."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -483,6 +502,7 @@ def test_update_experiment_run_invalid_update_type(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.send_notification = MagicMock()
@@ -501,7 +521,7 @@ def test_update_experiment_run_invalid_update_type(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_no_rows_updated(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run raises error when no rows are updated."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -516,6 +536,7 @@ def test_update_experiment_run_no_rows_updated(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    async def mock_execute_update(*args, **kwargs):
@@ -539,7 +560,7 @@ def test_update_experiment_run_no_rows_updated(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_status_with_error_missing_status(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with STATUS_WITH_ERROR but missing status - covers line 179."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -554,6 +575,7 @@ def test_update_experiment_run_status_with_error_missing_status(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.send_notification = MagicMock()
@@ -573,7 +595,7 @@ def test_update_experiment_run_status_with_error_missing_status(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_update_experiment_run_model_saved_missing_status(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test update_experiment_run with MODEL_SAVED but missing status - covers line 204."""
    from model_manager.activities.experiment_tracking import ExperimentTracking, UpdateType
@@ -588,6 +610,7 @@ def test_update_experiment_run_model_saved_missing_status(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.send_notification = MagicMock()
@@ -607,7 +630,7 @@ def test_update_experiment_run_model_saved_missing_status(

@patch('model_manager.activities.experiment_tracking.Postgres.__init__', return_value=None)
 def test_experiment_tracking_del_with_engine_no_super_del(
-    mock_postgres_init, db_config, mock_logger, mock_notification_handler
+    mock_postgres_init, db_config, mock_logger, mock_notification_handler, mock_metrics_controller
 ):
    """Test __del__ when engine exists but super has no __del__ - covers line 103."""
    from model_manager.activities.experiment_tracking import ExperimentTracking
@@ -622,6 +645,7 @@ def test_experiment_tracking_del_with_engine_no_super_del(
        max_connections=db_config['max_connections'],
        logger=mock_logger,
        notification_handler=mock_notification_handler,
+        metrics_controller=mock_metrics_controller,
    )

    et.engine = MagicMock()