SIENTIAPDE-1307: Integrate metrics controller and update sientia-dataops-library to 1.5.1. This change adds metrics collection capabilities to activities and updates the dataops library dependency. (18 files changed, 143 insertions(+), 16 deletions(-))

model_manager/activities/activities.py

@@ -5,6 +5,7 @@ with workflow.unsafe.imports_passed_through():
 
     from sientia_do.notifications.handlers import CoreNotificationHandler as NotificationHandler
     from sientia_do.observability.logger import Logger
+    from sientia_do.observability.metrics_controller import MetricsController
 
     from model_manager.activities.experiment_tracking import ExperimentTracking
     from model_manager.activities.training import Training
@@ -61,7 +62,10 @@ class Activities(ExperimentTracking, Training):
         Raises:
             Exception: If any parent class initialization fails
         """
-        # Initialize parent classes
+        metrics_controller = MetricsController(
+            logger=logger,
+        )
+
         ExperimentTracking.__init__(
             self,
             host=postgres_config['host'],
@@ -73,6 +77,7 @@ class Activities(ExperimentTracking, Training):
             max_connections=postgres_config['max_connections'],
             logger=logger,
             notification_handler=notification_handler,
+            metrics_controller=metrics_controller,
         )
 
         self.model_repository = ModelRepository(
@@ -101,6 +106,7 @@ class Activities(ExperimentTracking, Training):
             storage_repository=self.storage_repository,
             logger=logger,
             notification_handler=notification_handler,
+            metrics_controller=metrics_controller,
         )
 
     def __del__(self):

model_manager/activities/experiment_tracking.py

@@ -19,6 +19,7 @@ with workflow.unsafe.imports_passed_through():
     from sientia_do.notifications.handlers import CoreNotificationHandler as NotificationHandler
     from sientia_do.notifications.models import NotificationLevel
     from sientia_do.observability.logger import Logger
+    from sientia_do.observability.metrics_controller import MetricsController
     from sientia_do.temporal.activities.postgres import Postgres
     from sqlalchemy import text
 
@@ -42,10 +43,6 @@ class ExperimentTracking(Postgres):
 
     The activity uses the existing Postgres connection pool and adds experiment-specific
     operations with proper error handling and notifications.
-
-    Attributes:
-        logger (Logger): Logger instance for observability
-        notification_handler (NotificationHandler): Handler for sending notifications
     """
 
     def __init__(
@@ -59,6 +56,7 @@ class ExperimentTracking(Postgres):
         max_connections: int,
         logger: Logger,
         notification_handler: NotificationHandler,
+        metrics_controller: MetricsController,
     ):
         """
         Initialize ExperimentTracking activity with database configuration.
@@ -73,6 +71,7 @@ class ExperimentTracking(Postgres):
             max_connections: Maximum connections in pool
             logger: Logger instance for observability
             notification_handler: Notification handler for alerts
+            metrics_controller: Metrics controller for observability
 
         Raises:
             ConnectionError: If database connection cannot be established
@@ -87,6 +86,7 @@ class ExperimentTracking(Postgres):
             max_connections=max_connections,
             logger=logger,
             notification_handler=notification_handler,
+            metrics_controller=metrics_controller,
         )
 
     def __del__(self):

model_manager/activities/training.py

@@ -15,7 +15,8 @@ with workflow.unsafe.imports_passed_through():
     from sientia_do.notifications.handlers import CoreNotificationHandler as NotificationHandler
     from sientia_do.notifications.models import NotificationLevel
     from sientia_do.observability.logger import Logger
-    from sientia_do.temporal.activities.base import BaseActivity
+    from sientia_do.observability.metrics_controller import MetricsController
+    from sientia_do.observability.sientia_monitoring import SientiaMonitoring
 
     from model_manager.utils.exceptions import ModelTrainingError
     from model_manager.utils.models.train_model_params import TrainModelParams
@@ -24,18 +25,14 @@ with workflow.unsafe.imports_passed_through():
     from model_manager.utils.repository.training_repository import TrainingRepository
 
 
-class Training(BaseActivity):
+class Training(SientiaMonitoring):
     """
     Activity for ML model training operations.
 
-    This activity extends BaseActivity and handles machine learning model
+    This activity extends SientiaMonitoring and handles machine learning model
     training with comprehensive error handling. It receives pre-downloaded
     files from the workflow and returns success/failure status without
     raising exceptions.
-
-    Attributes:
-        logger (Logger): Logger instance for observability (inherited from BaseActivity)
-        notification_handler (NotificationHandler): Handler for sending notifications (inherited)
     """
 
     def __init__(
@@ -44,6 +41,7 @@ class Training(BaseActivity):
         storage_repository: StorageRepository,
         logger: Logger,
         notification_handler: NotificationHandler,
+        metrics_controller: MetricsController,
     ):
         """
         Initialize Training activity.
@@ -52,7 +50,7 @@ class Training(BaseActivity):
             logger: Logger instance for observability
             notification_handler: Handler for sending notifications
         """
-        super().__init__(logger, notification_handler, set_error_counter=True)
+        super().__init__(logger, notification_handler, metrics_controller, set_error_counter=True)
         self.training_repository = TrainingRepository(logger)
         self.model_repository = model_repository
         self.storage_repository = storage_repository