Merge branch 'main' into release/SIENTIAPDE-1645

tests/activities/test_training.py

@@ -342,7 +342,6 @@ def test_train_model_training_fails(
 ):
     """Test train_model when training fails."""
     from model_manager.activities.training import Training
-    from model_manager.utils.exceptions import ModelTrainingError
 
     training = Training(
         model_repository=mock_model_repository,
@@ -362,11 +361,10 @@ def test_train_model_training_fails(
         'train_params': mock_train_params,
     }
 
-    with pytest.raises(ModelTrainingError) as exc_info:
+    with pytest.raises(RuntimeError) as exc_info:
         asyncio.run(training.train_model(input_data))
 
-    assert exc_info.value.model_trained is False
-    assert exc_info.value.model_saved is False
+    assert str(exc_info.value) == 'Training failed'
     training.send_notification.assert_called_once()
 
 
@@ -382,7 +380,6 @@ def test_train_model_save_fails(
 ):
     """Test train_model when model saving fails."""
     from model_manager.activities.training import Training
-    from model_manager.utils.exceptions import ModelTrainingError
 
     training = Training(
         model_repository=mock_model_repository,
@@ -406,11 +403,10 @@ def test_train_model_save_fails(
         'train_params': mock_train_params,
     }
 
-    with pytest.raises(ModelTrainingError) as exc_info:
+    with pytest.raises(RuntimeError) as exc_info:
         asyncio.run(training.train_model(input_data))
 
-    assert exc_info.value.model_trained is True
-    assert exc_info.value.model_saved is False
+    assert str(exc_info.value) == 'Save failed'
     training.send_notification.assert_called_once()
 
 
@@ -437,14 +433,11 @@ def test_cleanup_resources_success(
     input_data = {
         'metadata': {'workflow_id': 'test-123'},
         'run_dir': '/tmp/run_001',  # noqa: S108
-        'bucket_name': 'test-bucket',
-        'file_name': 'test-file.csv',
     }
 
     asyncio.run(training.cleanup_resources(input_data))
 
     mock_model_repository.cleanup_run_directory.assert_called_once_with('/tmp/run_001')  # noqa: S108
-    mock_storage_repository.delete_file.assert_called_once_with('test-bucket', 'test-file.csv')
 
 
 @patch('model_manager.activities.training.TrainingRepository')
@@ -510,4 +503,3 @@ def test_cleanup_resources_with_empty_values(
     asyncio.run(training.cleanup_resources(input_data))
 
     mock_model_repository.cleanup_run_directory.assert_called_once_with('')
-    mock_storage_repository.delete_file.assert_called_once_with('', '')