SIENTIAPDE-1255: Add comprehensive tests for __del__ methods in Activities and ExperimentTracking to ensure proper resource cleanup and exception handling.

tests/activities/test_experiment_tracking.py

@@ -383,3 +383,182 @@ def test_update_type_enum_values():
     assert UpdateType.STATUS == 'status'
     assert UpdateType.STATUS_WITH_ERROR == 'status_with_error'
     assert UpdateType.MODEL_SAVED == 'model_saved'
+
+
+# Tests for __del__ method - 100% coverage
+
+
+@patch('model_manager.activities.experiment_tracking.Postgres.__init__')
+def test___del___with_engine_and_parent_del_exists(mock_postgres_init):
+    """Test __del__ calls parent destructor when engine exists and parent has __del__."""
+    mock_postgres_init.return_value = None
+
+    tracking = ExperimentTracking(
+        host='localhost',
+        port=5432,
+        user='test',
+        password='test',
+        dbname='test',
+        min_connections=1,
+        max_connections=10,
+        logger=MagicMock(),
+        notification_handler=MagicMock(),
+    )
+
+    # Add engine attribute to simulate Postgres initialization
+    tracking.engine = MagicMock()
+
+    # Track if parent __del__ was called
+    parent_del_called = []
+
+    def mock_parent_del(self):
+        """Mock parent __del__ that tracks when it's called."""
+        parent_del_called.append(True)
+
+    # Patch parent class to have __del__ method
+    with patch.object(type(tracking).__bases__[0], '__del__', mock_parent_del, create=True):
+        # Trigger __del__ - should call parent __del__ (line 103)
+        tracking.__del__()
+
+        # Verify parent __del__ was called (line 103 executed)
+        assert len(parent_del_called) == 1, 'Parent __del__ should have been called once'
+
+
+@patch('model_manager.activities.experiment_tracking.Postgres.__init__')
+def test___del___without_engine(mock_postgres_init):
+    """Test __del__ does not call parent destructor when engine attribute is missing."""
+    mock_postgres_init.return_value = None
+
+    tracking = ExperimentTracking(
+        host='localhost',
+        port=5432,
+        user='test',
+        password='test',
+        dbname='test',
+        min_connections=1,
+        max_connections=10,
+        logger=MagicMock(),
+        notification_handler=MagicMock(),
+    )
+
+    # Ensure engine attribute does not exist
+    if hasattr(tracking, 'engine'):
+        delattr(tracking, 'engine')
+
+    # Mock parent __del__ to track if it's called
+    mock_parent_del = MagicMock()
+
+    with patch.object(type(tracking).__bases__[0], '__del__', mock_parent_del, create=True):
+        # Trigger __del__ - should NOT call parent __del__ (line 100 is False)
+        tracking.__del__()
+
+        # Verify parent __del__ was NOT called
+        mock_parent_del.assert_not_called()
+
+
+@patch('model_manager.activities.experiment_tracking.Postgres.__init__')
+def test___del___when_parent_has_no_del_method(mock_postgres_init):
+    """Test __del__ handles case when parent class has no __del__ method - covers line 102 false branch."""
+    mock_postgres_init.return_value = None
+
+    tracking = ExperimentTracking(
+        host='localhost',
+        port=5432,
+        user='test',
+        password='test',
+        dbname='test',
+        min_connections=1,
+        max_connections=10,
+        logger=MagicMock(),
+        notification_handler=MagicMock(),
+    )
+
+    # Add engine attribute to pass the first hasattr check (line 100)
+    tracking.engine = MagicMock()
+
+    # Create a mock class without __del__ method
+    class MockSuperWithoutDel:
+        """Mock class that explicitly does not have __del__ method."""
+
+        pass
+
+    # Patch super() to return an instance without __del__
+    mock_super_instance = MockSuperWithoutDel()
+
+    with patch('builtins.super', return_value=mock_super_instance):
+        # Trigger __del__ - should handle the case when hasattr(super(), '__del__') is False (line 102)
+        try:
+            tracking.__del__()
+            # Test passes - the false branch of line 102 was executed without error
+        except Exception as e:
+            raise AssertionError(
+                f'__del__ should handle super() without __del__ method, but raised: {e}'
+            ) from e
+
+
+@patch('model_manager.activities.experiment_tracking.Postgres.__init__')
+def test___del___handles_exception_from_parent_del(mock_postgres_init):
+    """Test __del__ handles exceptions from parent destructor gracefully - covers line 104."""
+    mock_postgres_init.return_value = None
+
+    tracking = ExperimentTracking(
+        host='localhost',
+        port=5432,
+        user='test',
+        password='test',
+        dbname='test',
+        min_connections=1,
+        max_connections=10,
+        logger=MagicMock(),
+        notification_handler=MagicMock(),
+    )
+
+    # Add engine attribute
+    tracking.engine = MagicMock()
+
+    # Mock parent __del__ to raise an exception
+    mock_parent_del = MagicMock(side_effect=RuntimeError('Cleanup failed'))
+
+    with patch.object(type(tracking).__bases__[0], '__del__', mock_parent_del, create=True):
+        # Trigger __del__ - should catch exception and not propagate it (line 104-106)
+        try:
+            tracking.__del__()
+            # Test passes if no exception is raised
+        except Exception as e:
+            raise AssertionError(
+                f'__del__ should handle exceptions gracefully, but raised: {e}'
+            ) from e
+
+
+@patch('model_manager.activities.experiment_tracking.Postgres.__init__')
+def test___del___handles_attribute_error_from_parent_del(mock_postgres_init):
+    """Test __del__ handles AttributeError from parent destructor - covers line 104 exception handling."""
+    mock_postgres_init.return_value = None
+
+    tracking = ExperimentTracking(
+        host='localhost',
+        port=5432,
+        user='test',
+        password='test',
+        dbname='test',
+        min_connections=1,
+        max_connections=10,
+        logger=MagicMock(),
+        notification_handler=MagicMock(),
+    )
+
+    # Add engine attribute
+    tracking.engine = MagicMock()
+
+    # Mock parent __del__ to raise AttributeError
+    mock_parent_del = MagicMock(side_effect=AttributeError('engine not found'))
+
+    with patch.object(type(tracking).__bases__[0], '__del__', mock_parent_del, create=True):
+        # Trigger __del__ - should catch AttributeError and not propagate it
+        try:
+            tracking.__del__()
+            # Test passes if no exception is raised
+        except Exception as e:
+            raise AssertionError(
+                f'__del__ should handle AttributeError gracefully, but raised: {e}'
+            ) from e