From 9d4ec195863dd6490f36dfbb8ec724eca0f4f559 Mon Sep 17 00:00:00 2001
From: Bruno Domingues <bruno.domingues@aignosi.com.br>
Date: Mon, 13 Oct 2025 10:54:38 -0300
Subject: [PATCH] SIENTIAPDE-1252: Improve caching in quality gate, add alt
 text to logo, and change exception type in MLflow repository.

---
 .github/workflows/quality-gate.yml                 | 12 ++++++++----
 model_manager/reports/header.html                  |  1 +
 model_manager/utils/repository/model_repository.py |  2 +-
 tests/utils/repository/test_model_repository.py    |  2 +-
 4 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/quality-gate.yml b/.github/workflows/quality-gate.yml
index 1708d52..7add2b0 100644
--- a/.github/workflows/quality-gate.yml
+++ b/.github/workflows/quality-gate.yml
@@ -196,10 +196,14 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: "3.11"
-          cache: 'pip'
-          cache-dependency-path: |
-            requirements.txt
-            requirements-dev.txt
+
+      - name: 💾 Cache pip packages
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('requirements.txt', 'requirements-dev.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
 
       - name: 📦 Install Dependencies
         run: |
diff --git a/model_manager/reports/header.html b/model_manager/reports/header.html
index fd646a2..cd73a20 100644
--- a/model_manager/reports/header.html
+++ b/model_manager/reports/header.html
@@ -110,6 +110,7 @@
         <a href="#" class="logo">
           <img
             src="https://aignosi.blob.core.windows.net/sientia/20231016-Aignosi_Logo_WHITE.png"
+            alt="Aignosi Logo"
             width="247"
             height="70"
           />
diff --git a/model_manager/utils/repository/model_repository.py b/model_manager/utils/repository/model_repository.py
index ac6ad36..0630b71 100644
--- a/model_manager/utils/repository/model_repository.py
+++ b/model_manager/utils/repository/model_repository.py
@@ -607,7 +607,7 @@ class MLFlowRepository:
         except Exception as e:
             error_msg = f"Failed to save run '{data.run_name}' to MLflow: {str(e)}"
             self.logger.error(error_msg)
-            raise Exception(error_msg) from e
+            raise RuntimeError(error_msg) from e
 
     def _init_artifacts_data(self, data: TrainModelResult) -> tuple[pd.DataFrame, pd.DataFrame]:
         """
diff --git a/tests/utils/repository/test_model_repository.py b/tests/utils/repository/test_model_repository.py
index c1e0197..f77c8db 100644
--- a/tests/utils/repository/test_model_repository.py
+++ b/tests/utils/repository/test_model_repository.py
@@ -762,7 +762,7 @@ def test_save_run_mlflow_error(mock_path, mlflow_repository):
         'MLflow connection error'
     )
 
-    with pytest.raises(Exception) as exc_info:
+    with pytest.raises(RuntimeError) as exc_info:
         mlflow_repository.save_run(data)
 
     assert 'Failed to save run' in str(exc_info.value)