SIENTIAPDE-1645: Remove validate.sh script, add jsonschema dependency, and improve test code readability
This commit is contained in:
@@ -237,7 +237,10 @@ def test_sientia_training_data_preparation_error_count_total_is_counter():
|
||||
from model_manager.metrics import SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL
|
||||
|
||||
assert isinstance(SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL, Counter)
|
||||
assert 'sientia_training_data_preparation_error_count' in SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL._name
|
||||
assert (
|
||||
'sientia_training_data_preparation_error_count'
|
||||
in SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL._name
|
||||
)
|
||||
_assert_training_labels(SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL)
|
||||
|
||||
|
||||
@@ -257,7 +260,10 @@ def test_sientia_training_model_fit_error_count_total_is_counter():
|
||||
from model_manager.metrics import SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL
|
||||
|
||||
assert isinstance(SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL, Counter)
|
||||
assert 'sientia_training_model_fit_error_count' in SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL._name
|
||||
assert (
|
||||
'sientia_training_model_fit_error_count'
|
||||
in SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL._name
|
||||
)
|
||||
_assert_training_labels(SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL)
|
||||
|
||||
|
||||
@@ -340,9 +346,15 @@ def test_sientia_training_info_is_gauge():
|
||||
assert SIENTIA_TRAINING_INFO._name == 'sientia_training_info'
|
||||
|
||||
expected_labels = {
|
||||
'pod_id', 'model_name', 'model_type',
|
||||
'dataset_train_rows', 'dataset_val_rows', 'feature_count',
|
||||
'mse', 'mae', 'r2',
|
||||
'pod_id',
|
||||
'model_name',
|
||||
'model_type',
|
||||
'dataset_train_rows',
|
||||
'dataset_val_rows',
|
||||
'feature_count',
|
||||
'mse',
|
||||
'mae',
|
||||
'r2',
|
||||
}
|
||||
assert expected_labels == set(SIENTIA_TRAINING_INFO._labelnames)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user