gitea_admin/sientia-dataops-model-manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SIENTIAPDE-1645: Remove validate.sh script, add jsonschema dependency, and improve test code readability

Browse Source
This commit is contained in:
Bruno Domingues
2026-08-05 11:23:22 -03:00
parent ebc7e5ce6f
commit 4133e200f7
4 changed files with 38 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/activities/test_training.py
View File

@@ -369,7 +369,10 @@ def test_prepare_data_increments_error_counter_and_still_observes_lag_on_failure
training.observe_lag_sync.assert_called_once()
training.emit_metric_sync.assert_called_once()
call_args = training.emit_metric_sync.call_args
assert call_args.kwargs['metric_object'] is mm_metrics.SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL
assert (
call_args.kwargs['metric_object']
is mm_metrics.SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL
)
def test_fit_model_observes_lag_on_success(training):
@@ -419,12 +422,16 @@ def test_fit_model_increments_error_counter_on_failure(training):
training.observe_lag_sync.assert_called_once()
training.emit_metric_sync.assert_called_once()
call_args = training.emit_metric_sync.call_args
assert call_args.kwargs['metric_object'] is mm_metrics.SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL
assert (
call_args.kwargs['metric_object'] is mm_metrics.SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL
)
@patch('model_manager.activities.training.mm_metrics')
@patch('model_manager.activities.training.mlflow')
def test_train_model_sets_quality_gauges_after_compute_metrics(mock_mlflow, mock_mm_metrics, training):
def test_train_model_sets_quality_gauges_after_compute_metrics(
mock_mlflow, mock_mm_metrics, training
):
tp = TrainModelParams.from_dict(
{**_minimal_params_dict(), 'model_metadata': {'schemas': {'components': {'schemas': {}}}}}
)
@@ -473,9 +480,15 @@ def test_train_model_sets_quality_gauges_after_compute_metrics(mock_mlflow, mock
training.train_model({'metadata': {}, 'train_params': tp.to_dict()})
mock_mm_metrics.SIENTIA_TRAINING_MODEL_QUALITY_MSE.labels.return_value.set.assert_called_once_with(0.5)
mock_mm_metrics.SIENTIA_TRAINING_MODEL_QUALITY_MAE.labels.return_value.set.assert_called_once_with(0.3)
mock_mm_metrics.SIENTIA_TRAINING_MODEL_QUALITY_R2.labels.return_value.set.assert_called_once_with(-0.1)
mock_mm_metrics.SIENTIA_TRAINING_MODEL_QUALITY_MSE.labels.return_value.set.assert_called_once_with(
0.5
)
mock_mm_metrics.SIENTIA_TRAINING_MODEL_QUALITY_MAE.labels.return_value.set.assert_called_once_with(
0.3
)
mock_mm_metrics.SIENTIA_TRAINING_MODEL_QUALITY_R2.labels.return_value.set.assert_called_once_with(
-0.1
)
@patch('model_manager.activities.training.mm_metrics')

22
tests/test_metrics.py
View File

@@ -237,7 +237,10 @@ def test_sientia_training_data_preparation_error_count_total_is_counter():
from model_manager.metrics import SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL
assert isinstance(SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL, Counter)
assert 'sientia_training_data_preparation_error_count' in SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL._name
assert (
'sientia_training_data_preparation_error_count'
in SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL._name
)
_assert_training_labels(SIENTIA_TRAINING_DATA_PREPARATION_ERROR_COUNT_TOTAL)
@@ -257,7 +260,10 @@ def test_sientia_training_model_fit_error_count_total_is_counter():
from model_manager.metrics import SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL
assert isinstance(SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL, Counter)
assert 'sientia_training_model_fit_error_count' in SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL._name
assert (
'sientia_training_model_fit_error_count'
in SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL._name
)
_assert_training_labels(SIENTIA_TRAINING_MODEL_FIT_ERROR_COUNT_TOTAL)
@@ -340,9 +346,15 @@ def test_sientia_training_info_is_gauge():
assert SIENTIA_TRAINING_INFO._name == 'sientia_training_info'
expected_labels = {
'pod_id', 'model_name', 'model_type',
'dataset_train_rows', 'dataset_val_rows', 'feature_count',
'mse', 'mae', 'r2',
'pod_id',
'model_name',
'model_type',
'dataset_train_rows',
'dataset_val_rows',
'feature_count',
'mse',
'mae',
'r2',
}
assert expected_labels == set(SIENTIA_TRAINING_INFO._labelnames)