feat: enhance configuration and error handling in project setup
- Added new ignore rule for Ruff to allow temporary paths in tests. - Introduced MyPy overrides for specific modules to ignore errors. - Refactored `Cleanup` and `ExperimentTracking` classes to remove async keywords from methods, improving consistency in method signatures. - Updated `Training` class methods to handle synchronous operations, enhancing performance and clarity. - Adjusted `requirements.txt` to remove unnecessary Git dependency, streamlining project setup.
This commit is contained in:
@@ -125,7 +125,7 @@ def test_start_prometheus_server_success(
|
||||
mock_app_up = Mock()
|
||||
mock_metrics.APP_UP.labels.return_value = mock_app_up
|
||||
|
||||
metadata = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
metadata: dict[str, str | None] = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
|
||||
start_prometheus_server(mock_logger, metadata)
|
||||
|
||||
@@ -148,7 +148,7 @@ def test_start_prometheus_server_custom_port(mock_metrics, mock_start_http_serve
|
||||
mock_app_up = Mock()
|
||||
mock_metrics.APP_UP.labels.return_value = mock_app_up
|
||||
|
||||
metadata = {'pod_id': 'custom-pod', 'workflow_name': 'train_model'}
|
||||
metadata: dict[str, str | None] = {'pod_id': 'custom-pod', 'workflow_name': 'train_model'}
|
||||
|
||||
start_prometheus_server(mock_logger, metadata)
|
||||
|
||||
@@ -166,7 +166,7 @@ def test_start_prometheus_server_failure(
|
||||
|
||||
mock_start_http_server.side_effect = OSError('Port already in use')
|
||||
|
||||
metadata = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
metadata: dict[str, str | None] = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
|
||||
start_prometheus_server(mock_logger, metadata)
|
||||
|
||||
@@ -252,9 +252,7 @@ async def test_main_successful_startup(
|
||||
mock_runtime_class.return_value = mock_runtime
|
||||
|
||||
mock_client_instance = AsyncMock()
|
||||
mock_client_instance.config = Mock(
|
||||
return_value={'plugins': [], 'interceptors': []}
|
||||
)
|
||||
mock_client_instance.config = Mock(return_value={'plugins': [], 'interceptors': []})
|
||||
mock_client_class.connect = AsyncMock(return_value=mock_client_instance)
|
||||
|
||||
mock_worker_instance = Mock()
|
||||
@@ -347,9 +345,7 @@ async def test_main_handles_exception(
|
||||
mock_runtime_class.return_value = mock_runtime
|
||||
|
||||
mock_client_instance = AsyncMock()
|
||||
mock_client_instance.config = Mock(
|
||||
return_value={'plugins': [], 'interceptors': []}
|
||||
)
|
||||
mock_client_instance.config = Mock(return_value={'plugins': [], 'interceptors': []})
|
||||
mock_client_class.connect = AsyncMock(return_value=mock_client_instance)
|
||||
|
||||
mock_worker_instance = Mock()
|
||||
@@ -486,9 +482,7 @@ async def test_main_temporal_client_configuration(
|
||||
mock_runtime_class.return_value = mock_runtime
|
||||
|
||||
mock_client_instance = AsyncMock()
|
||||
mock_client_instance.config = Mock(
|
||||
return_value={'plugins': [], 'interceptors': []}
|
||||
)
|
||||
mock_client_instance.config = Mock(return_value={'plugins': [], 'interceptors': []})
|
||||
mock_client_class.connect = AsyncMock(return_value=mock_client_instance)
|
||||
|
||||
mock_worker_instance = Mock()
|
||||
@@ -581,9 +575,7 @@ async def test_main_worker_configuration(
|
||||
mock_runtime_class.return_value = mock_runtime
|
||||
|
||||
mock_client_instance = AsyncMock()
|
||||
mock_client_instance.config = Mock(
|
||||
return_value={'plugins': [], 'interceptors': []}
|
||||
)
|
||||
mock_client_instance.config = Mock(return_value={'plugins': [], 'interceptors': []})
|
||||
mock_client_class.connect = AsyncMock(return_value=mock_client_instance)
|
||||
|
||||
mock_worker_instance = Mock()
|
||||
@@ -703,9 +695,7 @@ async def test_main_schedule_creation_failure_does_not_stop_worker(
|
||||
mock_runtime_class.return_value = mock_runtime
|
||||
|
||||
mock_client_instance = AsyncMock()
|
||||
mock_client_instance.config = Mock(
|
||||
return_value={'plugins': [], 'interceptors': []}
|
||||
)
|
||||
mock_client_instance.config = Mock(return_value={'plugins': [], 'interceptors': []})
|
||||
mock_client_class.connect = AsyncMock(return_value=mock_client_instance)
|
||||
|
||||
mock_worker_instance = Mock()
|
||||
@@ -844,7 +834,7 @@ def test_start_prometheus_server_prints_success(
|
||||
mock_app_up = Mock()
|
||||
mock_metrics.APP_UP.labels.return_value = mock_app_up
|
||||
|
||||
metadata = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
metadata: dict[str, str | None] = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
|
||||
start_prometheus_server(mock_logger, metadata)
|
||||
|
||||
@@ -863,7 +853,7 @@ def test_start_prometheus_server_prints_failure(
|
||||
|
||||
mock_start_http_server.side_effect = Exception('Test error')
|
||||
|
||||
metadata = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
metadata: dict[str, str | None] = {'pod_id': 'test-pod-123', 'workflow_name': 'train_model'}
|
||||
|
||||
start_prometheus_server(mock_logger, metadata)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user