From fdaf48ddc9e9745f10c162c8e9be157b29d13be1 Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Mon, 13 Oct 2025 15:12:20 -0300 Subject: [PATCH] SIENTIAPDE-1231 Update values.yaml and model_repository.py for configuration and error handling improvements - Increased replicaCount from 1 to 2 in values.yaml for enhanced scalability. - Updated image tag from "0.0.2" to "0.0.3" in values.yaml to reflect the latest version. - Enhanced error messaging in model_repository.py to include the actual index type when raising ValueError for index type validation. --- laborious/utils/repository/model_repository.py | 6 +++--- values.yaml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/laborious/utils/repository/model_repository.py b/laborious/utils/repository/model_repository.py index 3652c25..33611bb 100644 --- a/laborious/utils/repository/model_repository.py +++ b/laborious/utils/repository/model_repository.py @@ -455,12 +455,12 @@ class MLFlowRepository(): self.logger.custom_info(f"Index type: {index_type}", metadata) - message = f"Index must be all timestamp like column. Valid formats are: pandas Timestamp, datetime, string in format {DATETIME_FORMAT_WITH_TZ}" + message = f"Index must be all timestamp like column. Valid formats are: pandas Timestamp, datetime, string in format {DATETIME_FORMAT_WITH_TZ}. Got {index_type}." # Check if all in index are of the same type if not all(isinstance(i, index_type) for i in index): raise ValueError( - f"{message}") + f"{message}. Elements are {','.join(map(type, index))}") # Check type and converts to DATETIME_FORMAT_WITH_TZ if index_type == str: @@ -896,7 +896,7 @@ class MLFlowRepository(): data_path = f"{model_temp_path}/retrain_data.csv" - # data.to_csv(data_path, index=True) + data.to_csv(data_path, index=True) self.logger.custom_info( f"Starting model upload for {experiment_name} with run name {current_run_name}", metadata) diff --git a/values.yaml b/values.yaml index 3f2b9f8..1300546 100644 --- a/values.yaml +++ b/values.yaml @@ -3,7 +3,7 @@ # Declare variables to be passed into your templates. # This will set the replicaset count more information can be found here: https://kubernetes.io/docs/concepts/workloads/controllers/replicaset/ -replicaCount: 1 +replicaCount: 2 # This sets the container image more information can be found here: https://kubernetes.io/docs/concepts/containers/images/ image: @@ -11,7 +11,7 @@ image: # This sets the pull policy for images. pullPolicy: Always # Overrides the image tag whose default is the chart appVersion. - tag: "0.0.2" + tag: "0.0.3" 0# This is for the secrets for pulling an image from a private repository more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ imagePullSecrets: @@ -214,7 +214,7 @@ env: value: "1" - name: MINIO_ENDPOINT_URL - value: "http://sientia-minio-minio.sientia.svc.cluster.local:9000" + value: "http://minio.minio.svc.cluster.local:9000" - name: MINIO_ACCESS_KEY value: "admin" - name: MINIO_SECRET_KEY