SIENTIAPDE-1712

Refactor metrics and API handling for improved consistency and clarity

- Removed the SIENTIA_CORE_LABELS constant and replaced it with CORE_LABELS for uniformity across metrics.
- Updated the API class to ensure operation_type is always included in core labels for PI Web API metrics.
- Simplified metric tag handling in the Gates class by consolidating common tags into a single core_tags dictionary.
- Enhanced the PredictionProcess class to improve error handling and variable naming for clarity.

laborious/workflows/sub_workflows/prediction_process.py

@@ -98,13 +98,21 @@ class PredictionProcess:
                 model_config,
                 save_transform,
             )
-        finally:
             await workflow.execute_activity_method(
                 Activities.cleanup_minio_objects_expired,
                 {**metadata, 'data': data},
                 retry_policy=retry_policy,
                 start_to_close_timeout=timedelta(minutes=5),
             )
+        except Exception as e:
+            await workflow.execute_activity_method(
+                Activities.cleanup_minio_objects_expired,
+                {**metadata, 'data': data},
+                retry_policy=retry_policy,
+                start_to_close_timeout=timedelta(minutes=5),
+            )
+            raise e
+            
 
     async def _run_prediction_pipeline(
         self,
@@ -140,7 +148,7 @@ class PredictionProcess:
             return
 
         # Request MLFlow model transformation
-        response_data = await workflow.execute_local_activity_method(
+        transformed_data = await workflow.execute_local_activity_method(
             Activities.request_transform,
             {**metadata, 'data': data, 'model_name': model_name, 'model_config': model_config},
             retry_policy=retry_policy,
@@ -153,7 +161,7 @@ class PredictionProcess:
             {
                 **metadata,
                 'filters': input_data['mlflow_transform_filters'],
-                'data': response_data,
+                'data': transformed_data,
                 'type': 'transform',
                 'path_priority': input_data['path_priority'],
             },
@@ -167,8 +175,6 @@ class PredictionProcess:
         ):
             return
 
-        transformed_data = response_data['content']
-
         path_flag, confidence, comment = await workflow.execute_local_activity_method(
             Activities.mlflow_content_gate,
             {
@@ -187,7 +193,7 @@ class PredictionProcess:
         ):
             return
 
-        response_data = await workflow.execute_local_activity_method(
+        predicted_data = await workflow.execute_local_activity_method(
             Activities.request_predict,
             {
                 **metadata,
@@ -205,7 +211,7 @@ class PredictionProcess:
             {
                 **metadata,
                 'filters': input_data['mlflow_predict_filters'],
-                'data': response_data,
+                'data': predicted_data,
                 'type': 'predict',
                 'path_priority': input_data['path_priority'],
             },
@@ -225,7 +231,7 @@ class PredictionProcess:
             {
                 'metadata': metadata,
                 'path_flag': path_flag,
-                'data': response_data['content'],
+                'data': predicted_data,
                 'transformed_data': transformed_data if save_transform else None,
                 'prediction_confidence': confidence,
                 'timestamp': last_timestamp,