SIENTIAPDE-994

Refactor tests for Postgres activities and improve error handling

- Updated test_postgres.py to enhance the testing of load_custom_query method, including cases for None data and date conversion.
- Refactored repeat_last_prediction tests to use mocks for SQLAlchemy session execution.
- Added tests for export_data_to_postgres method, covering both success and error scenarios.
- Improved the initialization tests for Activities class to ensure proper instantiation of dependencies.
- Enhanced test coverage for OPC repository connection validation.
- Updated tests for prediction workflows to streamline input handling and improve clarity.
- Introduced tests for connectors configuration to validate environment variable handling for MLFlow, OPC, and Postgres.
- Added tests for logger utility to ensure default settings are correctly applied.

tests/laborious/utils/repository/test_opc_repository.py

@@ -181,9 +181,26 @@ def test_validate_connection_lost_time_to_reconect(_mock_datetime, opc_repositor
     assert response == opc_repository.try_connect.return_value
 
 
+def test_validate_connection_failed(opc_repository):
+    opc_repository.client = MagicMock()
+    opc_repository.error_count = 0
+
+    output = opc_repository.validate_connection()
+    assert output is True
+
+
+def test_write_data_validate_connection_do_nothing(opc_repository):
+    opc_repository.validate_connection = MagicMock(return_value=True)
+    opc_repository.client = MagicMock()
+    opc_repository.write_data("ns=2;s=TestNode", 42.0, "float")
+    opc_repository.validate_connection.assert_called_once()
+    opc_repository.client.get_node.assert_called_once_with("ns=2;s=TestNode")
+
+
 def test_write_data_validate_connection_failed(opc_repository):
     opc_repository.validate_connection = MagicMock(return_value=False)
     opc_repository.client = MagicMock()
+    opc_repository.error_count = 0
     opc_repository.write_data("ns=2;s=TestNode", 42.0, "float")
     opc_repository.validate_connection.assert_called_once()
     opc_repository.client.get_node.assert_not_called()

tests/laborious/utils/test_connectors_config.py

@@ -0,0 +1,133 @@
+from os import environ
+from laborious.utils.connectors_config import (build_mlflow_config,
+                                               build_opc_config,
+                                               build_postgres_config)
+
+
+def test_build_mlflow_config_with_env_vars():
+    # Arrange
+    environ['MLFLOW_HOST'] = 'http://test-host'
+    environ['MLFLOW_PORT'] = '8080'
+    environ['MLFLOW_USERNAME'] = 'test-user'
+    environ['MLFLOW_PASSWORD'] = 'test-pass'
+
+    # Act
+    config = build_mlflow_config()
+
+    # Assert
+    assert config['host'] == 'http://test-host'
+    assert config['port'] == 8080
+    assert config['username'] == 'test-user'
+    assert config['password'] == 'test-pass'
+
+
+def test_build_mlflow_config_with_defaults():
+    # Arrange
+    # Clear any existing env vars
+    environ.pop('MLFLOW_HOST', None)
+    environ.pop('MLFLOW_PORT', None)
+    environ.pop('MLFLOW_USERNAME', None)
+    environ.pop('MLFLOW_PASSWORD', None)
+
+    # Act
+    config = build_mlflow_config()
+
+    # Assert
+    assert config['host'] == 'http://localhost'
+    assert config['port'] == 5080
+    assert config['username'] == 'aignosi'
+    assert config['password'] == 'aignosi'
+
+
+def test_build_opc_config_with_env_vars():
+    # Arrange
+    environ['OPC_CONFIG'] = '{"opc": {"name": "test-opc", "url": "opc.tcp://test:4840"}}'
+
+    # Act
+    config = build_opc_config()
+
+    # Assert
+    assert config['opc']['name'] == 'test-opc'
+    assert config['opc']['url'] == 'opc.tcp://test:4840'
+
+
+def test_build_opc_config_with_individual_env_vars():
+    # Arrange
+    environ.pop('OPC_CONFIG', None)
+    environ['OPC_NAME'] = 'test-name'
+    environ['OPC_URL'] = 'opc.tcp://test:4840'
+    environ['OPC_SERVER_URI'] = 'opc.tcp://test:4840'
+    environ['OPC_RECONNECTION_INTERVAL'] = '300'
+
+    # Act
+    config = build_opc_config()
+
+    # Assert
+    assert config['opc']['name'] == 'test-name'
+    assert config['opc']['url'] == 'opc.tcp://test:4840'
+    assert config['opc']['server_uri'] == 'opc.tcp://test:4840'
+    assert config['opc']['reconnection_interval'] == 300
+
+
+def test_build_opc_config_with_defaults():
+    # Arrange
+    environ.pop('OPC_CONFIG', None)
+    environ.pop('OPC_NAME', None)
+    environ.pop('OPC_URL', None)
+    environ.pop('OPC_SERVER_URI', None)
+    environ.pop('OPC_RECONNECTION_INTERVAL', None)
+
+    # Act
+    config = build_opc_config()
+
+    # Assert
+    assert config['opc']['name'] == 'opc'
+    assert config['opc']['url'] == 'opc.tcp://localhost:4840'
+    assert config['opc']['server_uri'] == 'opc.tcp://localhost:4840'
+    assert config['opc']['reconnection_interval'] == 120
+
+
+def test_build_postgres_config_with_env_vars():
+    # Arrange
+    environ['POSTGRES_HOST'] = 'test-host'
+    environ['POSTGRES_PORT'] = '5433'
+    environ['POSTGRES_USER'] = 'test-user'
+    environ['POSTGRES_PASSWORD'] = 'test-pass'
+    environ['POSTGRES_DBNAME'] = 'test-db'
+    environ['POSTGRES_MIN_CONNECTIONS'] = '10'
+    environ['POSTGRES_MAX_CONNECTIONS'] = '30'
+
+    # Act
+    config = build_postgres_config()
+
+    # Assert
+    assert config['host'] == 'test-host'
+    assert config['port'] == 5433
+    assert config['user'] == 'test-user'
+    assert config['password'] == 'test-pass'
+    assert config['dbname'] == 'test-db'
+    assert config['min_connections'] == 10
+    assert config['max_connections'] == 30
+
+
+def test_build_postgres_config_with_defaults():
+    # Arrange
+    environ.pop('POSTGRES_HOST', None)
+    environ.pop('POSTGRES_PORT', None)
+    environ.pop('POSTGRES_USER', None)
+    environ.pop('POSTGRES_PASSWORD', None)
+    environ.pop('POSTGRES_DBNAME', None)
+    environ.pop('POSTGRES_MIN_CONNECTIONS', None)
+    environ.pop('POSTGRES_MAX_CONNECTIONS', None)
+
+    # Act
+    config = build_postgres_config()
+
+    # Assert
+    assert config['host'] == 'localhost'
+    assert config['port'] == 5432
+    assert config['user'] == 'sientia'
+    assert config['password'] == 'sientia'
+    assert config['dbname'] == 'sientia'
+    assert config['min_connections'] == 5
+    assert config['max_connections'] == 20

tests/laborious/utils/test_logger.py

@@ -0,0 +1,37 @@
+import os
+from unittest.mock import patch
+import logging
+import pytest
+from laborious.utils.logger import get_logger
+
+
+@pytest.fixture
+def mock_env_vars():
+    with patch.dict(os.environ, {}, clear=True):
+        yield
+
+
+@pytest.mark.usefixtures("mock_env_vars")
+@patch('laborious.utils.logger.logging.Formatter')
+@patch('laborious.utils.logger.logging.StreamHandler')
+def test_get_logger_defaults(mock_stream_handler, mock_formatter):
+    """Test logger creation with default settings"""
+    # Mock the StreamHandler and Formatter
+
+    logger = get_logger('test_logger')
+
+    # Verify logger settings
+    assert logger.name == 'test_logger'
+    assert logger.level == logging.INFO
+
+    # Verify handler configuration
+    mock_stream_handler.return_value.setLevel.assert_called_once_with('INFO')
+    mock_stream_handler.return_value.setFormatter.assert_called_once()
+
+    # Verify formatter configuration
+    mock_formatter.assert_called_once_with(
+        '%(asctime)s - %(name)s - %(levelname)s - %(message)s'
+    )
+
+    # Verify handler was added to logger
+    assert len(logger.handlers) == 1