SIENTIAPDE-1273
Refactor Drift class to improve target name handling - Extracted target name from model configuration in the Drift class for better clarity and maintainability. - Updated test cases to reflect changes in input data structure, ensuring consistency in target name retrieval.
This commit is contained in:
@@ -32,6 +32,9 @@ class Drift:
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
model_config = input_data['model_config']
|
||||||
|
target_name = model_config['target']
|
||||||
|
|
||||||
gathering_query = f"""
|
gathering_query = f"""
|
||||||
SELECT *
|
SELECT *
|
||||||
FROM {input_data['schema']}.{input_data['source_table_name']}
|
FROM {input_data['schema']}.{input_data['source_table_name']}
|
||||||
@@ -76,7 +79,7 @@ class Drift:
|
|||||||
'reference_data': reference_data,
|
'reference_data': reference_data,
|
||||||
'model_name': input_data['model_name'],
|
'model_name': input_data['model_name'],
|
||||||
'model_id': input_data['model_id'],
|
'model_id': input_data['model_id'],
|
||||||
'target_name': input_data['target_name'],
|
'target_name': target_name,
|
||||||
'drift_metrics': input_data['drift_metrics'],
|
'drift_metrics': input_data['drift_metrics'],
|
||||||
'chunk_period': input_data.get('chunk_period', 'min'),
|
'chunk_period': input_data.get('chunk_period', 'min'),
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -34,7 +34,7 @@ async def test_run(workflow_mock: AsyncMock, drift: Drift):
|
|||||||
'source_table_name': 'test_source_table',
|
'source_table_name': 'test_source_table',
|
||||||
'target_table_name': 'test_target_table',
|
'target_table_name': 'test_target_table',
|
||||||
'interval': 60,
|
'interval': 60,
|
||||||
'target_name': 'test_target',
|
'model_config': {'target': 'test_target'},
|
||||||
'drift_metrics': ['psi', 'ks'],
|
'drift_metrics': ['psi', 'ks'],
|
||||||
'chunk_period': 'hour',
|
'chunk_period': 'hour',
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user