SIENTIAPDE-1478

Refactor Activities and API Integration for PI Web API

- Reintroduced the API import in the Activities class for proper integration.
- Cleaned up whitespace and formatting in the API class and related tests for improved readability.
- Updated test cases to ensure consistent formatting in error messages and configuration structures for PI Web API.
- Enhanced connectors_config.py with additional whitespace for better organization.

laborious/activities/activities.py

@@ -7,12 +7,12 @@ with workflow.unsafe.imports_passed_through():
     from sientia_do.notifications.handlers import CoreNotificationHandler as NotificationHandler
     from sientia_do.observability.logger import Logger
 
+    from laborious.activities.api import API
     from laborious.activities.gates import Gates
     from laborious.activities.mlflow import MLFlow
     from laborious.activities.model_metrics import ModelMetrics
     from laborious.activities.opc import OPC
     from laborious.activities.storage import Storage
-    from laborious.activities.api import API
 
 
 class Activities(Storage, MLFlow, Gates, OPC, ModelMetrics, API):
@@ -147,4 +147,4 @@ class Activities(Storage, MLFlow, Gates, OPC, ModelMetrics, API):
         Gates.close(self)
         await OPC.close(self)
         ModelMetrics.close(self)
-        API.close(self)
+        API.close(self)

laborious/activities/api.py

@@ -5,18 +5,17 @@ with workflow.unsafe.imports_passed_through():
     from typing import Any
 
     from pandas import DataFrame
-
     from sientia_do.notifications.handlers import NotificationHandler
     from sientia_do.notifications.models import NotificationLevel
     from sientia_do.observability.logger import Logger
     from sientia_do.observability.metrics_controller import MetricsController
     from sientia_do.observability.sientia_monitoring import SientiaMonitoring
-    from sientia_do.temporal.constants import DATETIME_FORMAT_WITH_TZ
     from sientia_do.repository.pi_web_api_client import PIWebAPIClient
 
 
 PI_WEB_API_PREDICTION_ERROR_CONFIDENCE = 13
 
+
 class API(SientiaMonitoring):
     """
     PI Web API operations for writing data to PI Web API.
@@ -78,7 +77,7 @@ class API(SientiaMonitoring):
         metadata = input_data['metadata']
         data = DataFrame(input_data['data'])
         pi_web_api_output_config = input_data['pi_web_api_output_config']
-        
+
         self.info('Writing data to PI Web API...', metadata)
 
         endpoint = pi_web_api_output_config['endpoint']
@@ -92,7 +91,6 @@ class API(SientiaMonitoring):
         confidence_value = data.head(1)['prediction_confidence'].values[0]
 
         try:
-
             await self.pi_web_api_client.write_value(
                 web_ids=prediction_tags,
                 value={
@@ -138,5 +136,5 @@ class API(SientiaMonitoring):
                 level=NotificationLevel.ERROR,
                 attachment_content=trace,
             )
-        
-        return data.to_dict()
+
+        return data.to_dict()

laborious/utils/connectors_config.py

@@ -2,6 +2,7 @@ import json
 from os import getenv
 from typing import Any
 
+
 def build_mlflow_config() -> dict[str, Any]:
     """
     Build MLFlow server configuration from environment variables.
@@ -66,6 +67,7 @@ def build_opc_config() -> dict[str, Any]:
         }
     }
 
+
 def build_minio_config() -> dict[str, Any]:
     """
     Build MinIO (S3-compatible) configuration from environment variables.

laborious/worker/worker.py

@@ -43,7 +43,6 @@ Poller Configuration:
 - POLLER_INITIAL: Initial number of pollers (default: 2)
 """
 
-
 from temporalio import client, workflow
 from temporalio.runtime import PrometheusConfig, Runtime, TelemetryConfig
 from temporalio.worker import (
@@ -55,10 +54,16 @@ from temporalio.worker import (
 
 with workflow.unsafe.imports_passed_through():
     import asyncio
+    import os
     import sys
     from datetime import timedelta
 
     from prometheus_client import start_http_server
+    from sientia_do.connectors_config import (
+        build_api_config,
+        build_mongodb_config,
+        build_postgres_config,
+    )
     from sientia_do.notifications.handlers import CoreNotificationHandler as NotificationHandler
     from sientia_do.observability.logger import get_logger
 
@@ -69,10 +74,6 @@ with workflow.unsafe.imports_passed_through():
         build_mlflow_config,
         build_opc_config,
     )
-    from sientia_do.connectors_config import (
-        build_postgres_config,
-        build_mongodb_config,
-    )
     from laborious.workflows.drift import Drift
     from laborious.workflows.minimal_retrain import MinimalRetrain
     from laborious.workflows.predictions_batch import PredictionsBatch
@@ -81,7 +82,6 @@ with workflow.unsafe.imports_passed_through():
         FormatAndExportPrediction,
     )
     from laborious.workflows.sub_workflows.prediction_process import PredictionProcess
-    import os
 
 POD_ID = os.getenv('POD_ID')
 SDK_METRICS_PORT = int(os.getenv('HTTP_SDK_METRICS_PORT', '9091'))
@@ -183,6 +183,7 @@ async def main():
         mlflow_config=build_mlflow_config(),
         minio_config=build_minio_config(),
         opc_config=build_opc_config(),
+        pi_web_api_config=build_api_config(),
         logger=logger,
         notification_handler=notification_handler,
     )

laborious/workflows/sub_workflows/format_and_export_prediction.py

@@ -154,7 +154,7 @@ class FormatAndExportPrediction:
             )
 
             write_transformed_handler = None
-        
+
         opc_metrics = {}
 
         # write to pi web api
@@ -197,7 +197,6 @@ class FormatAndExportPrediction:
             start_to_close_timeout=timedelta(seconds=180),
         )
 
-
         if write_transformed_handler is not None:
             await write_transformed_handler