SIENTIAPDE-1100

Improve error handling in OPC activities; raise exceptions instead of logging errors and add data type validation in OpcRepository

laborious/activities/opc.py

@@ -63,7 +63,7 @@ class OPC(BaseActivity):
                 level=NotificationLevel.ERROR,
                 attachment_content=trace
             )
-            self.logger.error(trace)
+            raise e
 
     @activity.defn(name='write_opc_data')
     async def write_opc_data(self, input_data: dict[str, Any]):

laborious/utils/repository/opc_repository.py

@@ -218,6 +218,15 @@ class OpcRepository():
             self.error_count += 1
             return
 
+        if data_type not in data_type_map:
+            self.notification_handler.build_and_send_notification(
+                notification_id=f"OPC_WRITE_DATA_TYPE_ERROR_{self.name}",
+                message=f"Unsupported data type: {data_type}",
+                block="opc_repository",
+                level=NotificationLevel.ERROR
+            )
+            return
+
         data = data_type_map[data_type]['converter'](value)
         self.logger.info(f'Writing {data} - {type(data)} to {node}')
         ua_data = DataValue(

tests/laborious/activities/test_opc.py

@@ -112,16 +112,22 @@ def test_write_data_success(opc, tag, data_type, data):
 def test_write_data_exception(opc):
     opc.opc_repository['server1'].write_data.side_effect = Exception(
         "Test error")
-    opc.write_data(server='server1', tag='tag1', data=50,
+
-                   data_type='int', tag_type='prediction')
+    try:
-    opc.notification_handler.build_and_send_notification.assert_called_once_with(
+        opc.write_data(server='server1', tag='tag1', data=50,
-        notification_id="WRITE_OPC_PREDICTION_ERROR",
+                       data_type='int', tag_type='prediction')
-        message="Error writing data to OPC server: Test error",
+
-        block="write_opc_data",
+    except Exception:
-        level=NotificationLevel.ERROR,
+        opc.notification_handler.build_and_send_notification.assert_called_once_with(
-        attachment_content=ANY
+            notification_id="WRITE_OPC_PREDICTION_ERROR",
-    )
+            message="Error writing data to OPC server: Test error",
-    opc.logger.error.assert_called_once()
+            block="write_opc_data",
+            level=NotificationLevel.ERROR,
+            attachment_content=ANY
+        )
+
+    else:
+        assert False, "Expected an exception to be raised"
 
 
 @mark.asyncio