SIENTIAPDE-1325

Update logging in MLFlowRepository and OpcRepository to use unified logging methods

- Refactored logging calls in MLFlowRepository to replace `self.logger.info` and `self.logger.debug` with `self.info` and `self.debug` for consistency.
- Updated connection logging in OpcRepository to format the connection message properly.
- Adjusted test cases to reflect changes in logging behavior and ensure proper assertions.

tests/laborious/activities/test_mlflow.py

@@ -255,9 +255,7 @@ async def test_retrain_model_success_data_success_retrain(mock_to_datetime, mlfl
     timestamp = raw_data.__getitem__.return_value.max.return_value
 
     raw_data.sort_values.assert_not_called()
-    raw_data.drop_duplicates.assert_called_once_with(
-        subset=['variable', 'timestamp'], keep='first'
-    )
+    raw_data.drop_duplicates.assert_called_once_with(subset=['variable', 'timestamp'], keep='first')
     raw_data = raw_data.drop_duplicates.return_value
 
     raw_data.drop.assert_has_calls(

tests/laborious/activities/test_opc.py

@@ -61,6 +61,7 @@ async def test_init_opc(mock_send_notification, mock_opc_repository):
     mock_notification_handler = MagicMock()
     servers = {
         'server1': {
+            'server_name': 'server1',
             'id': 'server1',
             'url': 'http://localhost:8080',
             'server_uri': 'opc.tcp://localhost:4840',
@@ -70,6 +71,7 @@ async def test_init_opc(mock_send_notification, mock_opc_repository):
             'reconnection_interval': 60,
         },
         'server2': {
+            'server_name': 'server2',
             'id': 'server2',
             'url': 'http://localhost:8080',
             'server_uri': 'opc.tcp://localhost:4840',
@@ -79,6 +81,7 @@ async def test_init_opc(mock_send_notification, mock_opc_repository):
             'reconnection_interval': 60,
         },
         'server3': {
+            'server_name': 'server3',
             'id': 'server3',
             'url': 'http://localhost:8080',
             'server_uri': 'opc.tcp://localhost:4840',
@@ -106,6 +109,7 @@ async def test_init_opc(mock_send_notification, mock_opc_repository):
         [
             call(
                 opc_id='server1',
+                server_name='server1',
                 url='http://localhost:8080',
                 logger=mock_logger,
                 server_uri='opc.tcp://localhost:4840',
@@ -122,6 +126,7 @@ async def test_init_opc(mock_send_notification, mock_opc_repository):
         [
             call(
                 opc_id='server2',
+                server_name='server2',
                 url='http://localhost:8080',
                 logger=mock_logger,
                 server_uri='opc.tcp://localhost:4840',
@@ -163,6 +168,7 @@ async def opc(mock_opc_repository):
     servers = {
         'server1': {
             'id': 'server1',
+            'server_name': 'server1',
             'url': 'http://localhost:8080',
             'server_uri': 'opc.tcp://localhost:4840',
             'cert_path': '',

tests/laborious/utils/repository/test_minio_repository.py

@@ -95,7 +95,6 @@ async def test_create_bucket_error(minio_repository):
     with raises(ValueError):
         await minio_repository.create_bucket({})
 
-
         minio_repository.s3_client.create_bucket.assert_called_once_with(Bucket='test')
         minio_repository.emit_metric.assert_called_once_with(
             metric_object=metrics.MINIO_WRITE_ERROR_COUNT, tags=ANY

tests/laborious/utils/repository/test_opc_repository.py

@@ -18,6 +18,7 @@ def mock_logger():
 def opc_repository(mock_logger):
     repository = OpcRepository(
         opc_id='test_repo',
+        server_name='test_server',
         url='opc.tcp://localhost:4840',
         logger=mock_logger,
         notification_handler=Mock(),
@@ -55,6 +56,7 @@ metadata = {
 
 def test_init(opc_repository):
     assert opc_repository.id == 'test_repo'
+    assert opc_repository.server_name == 'test_server'
     assert opc_repository.url == 'opc.tcp://localhost:4840'
     assert opc_repository.server_uri == 'urn:test:server'
     assert opc_repository.cert_path == '/path/to/cert.pem'
@@ -139,11 +141,13 @@ async def test_try_connect_success(opc_repository):
 @pytest.mark.asyncio
 async def test_try_connect_fail(opc_repository):
     opc_repository.last_reconnection_time = None
+    opc_repository.disconnect = AsyncMock()
     opc_repository.client = MagicMock()
     opc_repository.client.connect.side_effect = Exception('Test error')
 
     is_connected, error_data = await opc_repository.try_connect()
 
+    opc_repository.disconnect.assert_called_once()
     opc_repository.client.connect.assert_called_once()
     assert is_connected is False
     assert error_data['notification_id'] == f'OPC_CONNECTION_ERROR_{opc_repository.id}'