feature-rc/SIENTIAPDE-2164 -fix: apply Temporal replay-safe unpacking and guard against missing filter counters (review findings)

This commit is contained in:
Carla Pinto
2026-09-30 19:40:03 +02:00
parent a01763b69c
commit db32450c68
3 changed files with 26 additions and 4 deletions

View File

@@ -6,7 +6,7 @@ from sientia_do.notifications.models import NotificationLevel
from sientia_do.observability.metrics_controller import MetricsController
from sientia_do.observability.sientia_monitoring import SientiaMonitoring
from laborious.activities.gates import Gates
from laborious.activities.gates import Gates, input_filter_counters, input_filter_functions
@fixture(autouse=True)
@@ -136,6 +136,13 @@ def test_write_prediction_metadata_insert_failure_swallowed(gates_activity, mong
gates_activity.error.assert_called_once()
def test_input_filter_counters_covers_every_input_filter_function():
# A filter added to input_filter_functions without a matching entry here would degrade to
# counter=0 (see the `.get(..., lambda *_: 0)` fallback in input_gate) instead of crashing —
# but this test should still catch the gap before it ships (review finding, 2026-09-30).
assert set(input_filter_counters) == set(input_filter_functions)
def test_input_gate_invalid_filter(gates_activity, mongo: MagicMock):
# Arrange
input_data = {