SIENTIAPDE-994

Refactor activity methods and update requirements.txt to enhance functionality and remove deprecated filters. Added detailed docstrings for clarity and improved error handling in data processing workflows.
2025-05-09 16:27:57 -03:00
parent 43f19ed93a
commit d09fb6ac5e
22 changed files with 1435 additions and 160 deletions
--- a/tests/laborious/activities/test_opc.py
+++ b/tests/laborious/activities/test_opc.py
@@ -0,0 +1,178 @@
+from unittest.mock import patch, MagicMock
+
+from pytest import fixture, mark
+from laborious.activities.opc import OPC
+from sientia_do.notifications.models import NotificationLevel
+from unittest.mock import ANY
+
+
+@patch("laborious.activities.opc.OpcRepository")
+def test___init__(mock_opc_repository):
+    opc = OPC(
+        name="test",
+        url="http://localhost:8080",
+        server_uri="opc.tcp://localhost:4840",
+        cert_path="",
+        private_key_path="",
+        server_cert_path="",
+        logger=MagicMock(),
+        notification_handler=MagicMock()
+    )
+
+    assert opc.name == "test"
+    assert opc.url == "http://localhost:8080"
+    assert opc.server_uri == "opc.tcp://localhost:4840"
+    assert opc.cert_path == ""
+    assert opc.private_key_path == ""
+    assert opc.server_cert_path == ""
+    assert opc.opc_repository == mock_opc_repository.return_value
+
+    mock_opc_repository.assert_called_once_with(
+        name="test",
+        url="http://localhost:8080",
+        server_uri="opc.tcp://localhost:4840",
+        cert_path="",
+        private_key_path="",
+        server_cert_path="",
+        logger=opc.logger,
+    )
+
+    opc.opc_repository.connect.assert_called_once()
+
+
+@fixture
+@patch("laborious.activities.opc.OpcRepository")
+def opc(mock_opc_repository):
+    return OPC(
+        name="test",
+        url="http://localhost:8080",
+        server_uri="opc.tcp://localhost:4840",
+        cert_path="",
+        private_key_path="",
+        server_cert_path="",
+        logger=MagicMock(),
+        notification_handler=MagicMock()
+    )
+
+
+@mark.asyncio
+async def test_write_opc_data_success(opc):
+    # Arrange
+    input_data = {
+        'data': {
+            'prediction': [0.75],
+            'prediction_confidence': [0.95]
+        },
+        'opc_servers': ['server1'],
+        'opc_output_config': {
+            'prediction_tags': {
+                'tag1': {'data_type': 'float'}
+            },
+            'confidence_tags': {
+                'tag2': {'data_type': 'float'}
+            }
+        }
+    }
+
+    # Act
+    await opc.write_opc_data(input_data)
+
+    # Assert
+    opc.opc_repository.write_data.assert_any_call('tag1', 0.75, 'float')
+    opc.opc_repository.write_data.assert_any_call('tag2', 0.95, 'float')
+    assert opc.opc_repository.write_data.call_count == 2
+
+
+@mark.asyncio
+async def test_write_opc_data_prediction_error(opc):
+    # Arrange
+    input_data = {
+        'data': {
+            'prediction': [0.75],
+            'prediction_confidence': [0.95]
+        },
+        'opc_servers': ['server1'],
+        'opc_output_config': {
+            'prediction_tags': {
+                'tag1': {'data_type': 'float'}
+            }
+        }
+    }
+
+    opc.opc_repository.write_data.side_effect = Exception("Test error")
+
+    # Act
+    await opc.write_opc_data(input_data)
+
+    # Assert
+    opc.notification_handler.build_and_send_notification.assert_called_with(
+        notification_id="WRITE_OPC_PREDICTION_ERROR",
+        message="Error writing data to OPC server: Test error",
+        block="write_opc_data",
+        level=NotificationLevel.ERROR,
+        attachment_content=ANY
+    )
+    opc.logger.error.assert_called_once()
+
+
+@mark.asyncio
+async def test_write_opc_data_confidence_error(opc):
+    # Arrange
+    input_data = {
+        'data': {
+            'prediction': [0.75],
+            'prediction_confidence': [0.95]
+        },
+        'opc_servers': ['server1'],
+        'opc_output_config': {
+            'prediction_tags': {
+                'tag1': {'data_type': 'float'}
+            },
+            'confidence_tags': {
+                'tag2': {'data_type': 'float'}
+            }
+        }
+    }
+
+    # Make first call succeed but second fail
+    def side_effect(*args, **kwargs):
+        if args[0] == 'tag2':
+            raise ValueError("Test error")
+        return None
+
+    opc.opc_repository.write_data.side_effect = side_effect
+
+    # Act
+    await opc.write_opc_data(input_data)
+
+    # Assert
+    opc.notification_handler.build_and_send_notification.assert_called_with(
+        notification_id="WRITE_OPC_CONFIDENCE_ERROR",
+        message="Error writing data to OPC server: Test error",
+        block="write_opc_data",
+        level=NotificationLevel.ERROR,
+        attachment_content=ANY
+    )
+    opc.logger.error.assert_called_once()
+
+
+@mark.asyncio
+async def test_write_opc_data_empty_config(opc):
+    # Arrange
+    input_data = {
+        'data': {
+            'prediction': [0.75],
+            'prediction_confidence': [0.95]
+        },
+        'opc_servers': ['server1'],
+        'opc_output_config': {
+            'prediction_tags': {},
+            'confidence_tags': {}
+        }
+    }
+
+    # Act
+    await opc.write_opc_data(input_data)
+
+    # Assert
+    opc.opc_repository.write_data.assert_not_called()