fix(simple_metrics): ignore invalid simple_metrics_min_samples; tighten tests and docs (SIENTIAPDE-2189)
This commit is contained in:
@@ -34,6 +34,14 @@ class SimpleMetrics:
|
||||
model_type = model_config.get('model_type')
|
||||
thresholds = model_config.get('simple_metrics_thresholds')
|
||||
min_samples = model_config.get('simple_metrics_min_samples')
|
||||
# Untyped Mongo config: anything but a positive int (bool excluded) turns the guard off
|
||||
# instead of raising in workflow code; falsy values mean "unset" and stay silent.
|
||||
if type(min_samples) is not int or min_samples <= 0:
|
||||
if min_samples:
|
||||
workflow.logger.warning(
|
||||
f'Invalid simple_metrics_min_samples={min_samples!r}: min samples guard off'
|
||||
)
|
||||
min_samples = None
|
||||
|
||||
# Built from internal Temporal workflow config, not user input (bandit B608).
|
||||
query = f"""
|
||||
|
||||
Reference in New Issue
Block a user