From 46fe88f69e27ccd24c042bf2f77f0dea9492cfe9 Mon Sep 17 00:00:00 2001 From: vitor-aignosi Date: Mon, 17 Nov 2025 10:14:47 -0300 Subject: [PATCH] SIENTIAPDE-1273 Refactor return types in ModelMetrics class methods to enhance type clarity. Updated calculate_drift and calculate_simple_metrics methods to return lists of dictionaries instead of generic lists, improving type specificity for better data handling. --- laborious/activities/model_metrics.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/laborious/activities/model_metrics.py b/laborious/activities/model_metrics.py index a3deda8..dce8523 100644 --- a/laborious/activities/model_metrics.py +++ b/laborious/activities/model_metrics.py @@ -1,7 +1,7 @@ from temporalio import activity, workflow with workflow.unsafe.imports_passed_through(): - from typing import Any, Hashable + from typing import Any from pandas import DataFrame, Index, to_datetime @@ -138,7 +138,7 @@ class ModelMetrics(SientiaMonitoring): @activity.defn(name='calculate_drift') - async def calculate_drift(self, input_data: dict[str, Any]) -> list: + async def calculate_drift(self, input_data: dict[str, Any]) -> list[dict]: """ Calculate drift metrics for a model. @@ -266,7 +266,7 @@ class ModelMetrics(SientiaMonitoring): return drift_df.to_dict(orient='records') @activity.defn(name='calculate_simple_metrics') - async def calculate_simple_metrics(self, input_data: dict[str, Any]) -> list[dict[Hashable, Any]]: + async def calculate_simple_metrics(self, input_data: dict[str, Any]) -> list[dict]: """ Calculate simple metrics for a model. Metrics available are: - rmse