SIENTIAPDE-1712
Update environment variables in values.yaml and enhance metric labels in metrics.py - Changed POSTGRES_USER and POSTGRES_PASSWORD values in values.yaml for improved security. - Added 'runtime' label to metrics in metrics.py for better environment identification. - Updated CORE_LABELS to include 'runtime' for consistency across metrics. - Modified type hint for data parameter in PredictionProcess to use a dictionary for better clarity. - Adjusted tests to reflect changes in core labels and MinIO configuration.
This commit is contained in:
@@ -820,15 +820,17 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
'opc_metrics': {'server1': {'tag1': 0.1, 'tag2': 0.2}},
|
||||
}
|
||||
await gates_activity.write_metrics(input_data)
|
||||
core_tags = {
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'runtime': gates_activity.runtime,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
}
|
||||
gates_activity.emit_metric.assert_has_calls(
|
||||
[
|
||||
call(
|
||||
metric_object=mock_metrics.PREDICTIONS_WRITTEN_COUNT,
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
},
|
||||
tags=core_tags,
|
||||
),
|
||||
]
|
||||
)
|
||||
@@ -837,11 +839,7 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
call(
|
||||
metric_object=mock_metrics.PREDICTION_CONFIDENCE_MONITOR,
|
||||
method='set',
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
},
|
||||
tags=core_tags,
|
||||
value=0.9,
|
||||
),
|
||||
]
|
||||
@@ -851,11 +849,7 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
call(
|
||||
metric_object=mock_metrics.PREDICTION_RESPONSE_TIME_MONITOR,
|
||||
method='observe',
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
},
|
||||
tags=core_tags,
|
||||
value=0.1,
|
||||
),
|
||||
]
|
||||
@@ -865,9 +859,7 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
call(
|
||||
metric_object=mock_metrics.PREDICTION_OPC_WRITING_COUNT,
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
**core_tags,
|
||||
'opc_server_id': 'server1',
|
||||
'tag': 'tag1',
|
||||
},
|
||||
@@ -880,9 +872,7 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
metric_object=mock_metrics.PREDICTION_OPC_WRITING_RESPONSE_TIME_MONITOR,
|
||||
method='observe',
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
**core_tags,
|
||||
'opc_server_id': 'server1',
|
||||
'tag': 'tag1',
|
||||
},
|
||||
@@ -895,9 +885,7 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
call(
|
||||
metric_object=mock_metrics.PREDICTION_OPC_WRITING_COUNT,
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
**core_tags,
|
||||
'opc_server_id': 'server1',
|
||||
'tag': 'tag2',
|
||||
},
|
||||
@@ -910,9 +898,7 @@ async def test_write_metrics(mock_metrics, gates_activity):
|
||||
metric_object=mock_metrics.PREDICTION_OPC_WRITING_RESPONSE_TIME_MONITOR,
|
||||
method='observe',
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
**core_tags,
|
||||
'opc_server_id': 'server1',
|
||||
'tag': 'tag2',
|
||||
},
|
||||
@@ -943,6 +929,7 @@ async def test_write_metrics_with_none_opc_response_time(mock_metrics, gates_act
|
||||
method='observe',
|
||||
tags={
|
||||
'pod_id': gates_activity.pod_id,
|
||||
'runtime': gates_activity.runtime,
|
||||
'model_name': metadata['metadata']['model_name'],
|
||||
'workflow_name': metadata['metadata']['workflow_name'],
|
||||
'opc_server_id': 'server1',
|
||||
|
||||
Reference in New Issue
Block a user