rc/SIENTIAPDE-2165- refactor: inline counter=1 for API_ERROR, drop unnecessary dispatch (review finding)

This commit is contained in:
Carla Pinto
2026-10-08 13:58:55 +02:00
parent bba4daaddd
commit 2649476571
2 changed files with 10 additions and 44 deletions

View File

@@ -6,13 +6,7 @@ from sientia_do.notifications.models import NotificationLevel
from sientia_do.observability.metrics_controller import MetricsController
from sientia_do.observability.sientia_monitoring import SientiaMonitoring
from laborious.activities.gates import (
Gates,
input_filter_counters,
input_filter_functions,
mlflow_response_filter_counters,
mlflow_response_filter_functions,
)
from laborious.activities.gates import Gates, input_filter_counters, input_filter_functions
@fixture(autouse=True)
@@ -448,14 +442,6 @@ def test_mlflow_response_gate_with_filter_not_caught(gates_activity):
gates_activity.debug.assert_called()
def test_mlflow_response_filter_counters_covers_every_mlflow_response_filter_function():
# Same parity guard as `test_input_filter_counters_covers_every_input_filter_function`
# (review finding, 2026-09-30): a filter added to `mlflow_response_filter_functions` without
# a matching counter here degrades to counter=0 instead of crashing, but this test still
# catches the gap before it ships.
assert set(mlflow_response_filter_counters) == set(mlflow_response_filter_functions)
def test_mlflow_content_gate_invalid_filter(gates_activity):
# Arrange
input_data = {